From patchwork Wed Oct 10 13:20:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 1581211 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D8EC8DFABE for ; Thu, 11 Oct 2012 07:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755389Ab2JKHLV (ORCPT ); Thu, 11 Oct 2012 03:11:21 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:42800 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755131Ab2JKHLU (ORCPT ); Thu, 11 Oct 2012 03:11:20 -0400 Received: from finisterre.wolfsonmicro.main (unknown [203.226.202.110]) by opensource.wolfsonmicro.com (Postfix) with ESMTPSA id 58A5E110A97; Thu, 11 Oct 2012 08:11:18 +0100 (BST) Received: from broonie by finisterre.wolfsonmicro.main with local (Exim 4.80) (envelope-from ) id 1TLwDE-0001Ud-Tl; Wed, 10 Oct 2012 22:20:36 +0900 From: Mark Brown To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Mark Brown Subject: [PATCH 1/3] Input: wm831x-ts - Remove unneeded clearing of driver data Date: Wed, 10 Oct 2012 22:20:34 +0900 Message-Id: <1349875236-5707-1-git-send-email-broonie@opensource.wolfsonmicro.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This is unneeded, only a bound driver can use driver data and a driver relying on the state prior to probe() is buggy. Signed-off-by: Mark Brown --- drivers/input/touchscreen/wm831x-ts.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/wm831x-ts.c b/drivers/input/touchscreen/wm831x-ts.c index 52abb98..bf0a4a6 100644 --- a/drivers/input/touchscreen/wm831x-ts.c +++ b/drivers/input/touchscreen/wm831x-ts.c @@ -390,7 +390,6 @@ static __devexit int wm831x_ts_remove(struct platform_device *pdev) input_unregister_device(wm831x_ts->input_dev); kfree(wm831x_ts); - platform_set_drvdata(pdev, NULL); return 0; }