From patchwork Thu Dec 20 13:51:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 1899841 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 3195D3FC64 for ; Thu, 20 Dec 2012 13:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704Ab2LTNvd (ORCPT ); Thu, 20 Dec 2012 08:51:33 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:50895 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707Ab2LTNv3 (ORCPT ); Thu, 20 Dec 2012 08:51:29 -0500 Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1TlgX1-0003gu-Nl; Thu, 20 Dec 2012 14:51:27 +0100 Received: from wsa by dude.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1TlgX0-0004tV-12; Thu, 20 Dec 2012 14:51:26 +0100 From: Wolfram Sang To: linux-input@vger.kernel.org Cc: Michael Hennerich , Dmitry Torokhov , device-drivers-devel@blackfin.uclinux.org, Wolfram Sang Subject: [PATCH 2/4] input: adxl34x: don't set THRESH_TAP twice Date: Thu, 20 Dec 2012 14:51:09 +0100 Message-Id: <1356011471-18757-3-git-send-email-w.sang@pengutronix.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1356011471-18757-1-git-send-email-w.sang@pengutronix.de> References: <1356011471-18757-1-git-send-email-w.sang@pengutronix.de> X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The datasheet doesn't say anything about writing twice, so this was probably overlooked. Signed-off-by: Wolfram Sang --- drivers/input/misc/adxl34x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index b18d3e2..6be8687 100644 --- a/drivers/input/misc/adxl34x.c +++ b/drivers/input/misc/adxl34x.c @@ -827,7 +827,6 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq, if (err) goto err_remove_attr; - AC_WRITE(ac, THRESH_TAP, pdata->tap_threshold); AC_WRITE(ac, OFSX, pdata->x_axis_offset); ac->hwcal.x = pdata->x_axis_offset; AC_WRITE(ac, OFSY, pdata->y_axis_offset);