| Message ID | 1369681926-22185-18-git-send-email-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/27/2013 08:12 PM, Sebastian Andrzej Siewior wrote: > TI-adc reads a little better compared to tiadc. > While here add an alias so the driver is loaded on demand. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Jonathan Cameron <jic23@kernel.org> but you'll be wanting a few more acks on a name change... > --- > drivers/iio/adc/ti_am335x_adc.c | 4 ++-- > drivers/mfd/ti_am335x_tscadc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index 72ffe89..d0317fc 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -299,14 +299,14 @@ static const struct dev_pm_ops tiadc_pm_ops = { > > static struct platform_driver tiadc_driver = { > .driver = { > - .name = "tiadc", > + .name = "TI-adc", > .owner = THIS_MODULE, > .pm = TIADC_PM_OPS, > }, > .probe = tiadc_probe, > .remove = tiadc_remove, > }; > - > +MODULE_ALIAS("platform:TI-adc"); > module_platform_driver(tiadc_driver); > > MODULE_DESCRIPTION("TI ADC controller driver"); > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > index c25fe00..014df14 100644 > --- a/drivers/mfd/ti_am335x_tscadc.c > +++ b/drivers/mfd/ti_am335x_tscadc.c > @@ -193,7 +193,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > if (adc_channels > 0) { > tscadc->adc_cell = tscadc->used_cells; > cell = &tscadc->cells[tscadc->used_cells++]; > - cell->name = "tiadc"; > + cell->name = "TI-adc"; > cell->platform_data = tscadc; > cell->pdata_size = sizeof(*tscadc); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Jonathan Cameron | 2013-06-02 18:50:19 [+0100]: >On 05/27/2013 08:12 PM, Sebastian Andrzej Siewior wrote: >> TI-adc reads a little better compared to tiadc. >> While here add an alias so the driver is loaded on demand. >> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >Acked-by: Jonathan Cameron <jic23@kernel.org> > >but you'll be wanting a few more acks on a name change... It is a name change of a driver in tree (two to be exact) which can not be used as of now and has no users. I can't imagine why someone should complain. Thanks for the review. Sebatian -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 72ffe89..d0317fc 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c @@ -299,14 +299,14 @@ static const struct dev_pm_ops tiadc_pm_ops = { static struct platform_driver tiadc_driver = { .driver = { - .name = "tiadc", + .name = "TI-adc", .owner = THIS_MODULE, .pm = TIADC_PM_OPS, }, .probe = tiadc_probe, .remove = tiadc_remove, }; - +MODULE_ALIAS("platform:TI-adc"); module_platform_driver(tiadc_driver); MODULE_DESCRIPTION("TI ADC controller driver"); diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index c25fe00..014df14 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -193,7 +193,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) if (adc_channels > 0) { tscadc->adc_cell = tscadc->used_cells; cell = &tscadc->cells[tscadc->used_cells++]; - cell->name = "tiadc"; + cell->name = "TI-adc"; cell->platform_data = tscadc; cell->pdata_size = sizeof(*tscadc); }
TI-adc reads a little better compared to tiadc. While here add an alias so the driver is loaded on demand. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/iio/adc/ti_am335x_adc.c | 4 ++-- drivers/mfd/ti_am335x_tscadc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)