diff mbox

typo fixes (coordiante -> coordinate) in am335x

Message ID 1373901928-19605-1-git-send-email-zubair.lutfullah@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Zubair Lutfullah July 15, 2013, 3:25 p.m. UTC
Did a grep for coordiante and replaced them all
with coordinate.

This applies to the mfd-next tree.

Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com>
---
 .../bindings/input/touchscreen/ti-tsc-adc.txt      |    4 ++--
 arch/arm/boot/dts/am335x-evm.dts                   |    2 +-
 drivers/input/touchscreen/ti_am335x_tsc.c          |    2 +-
 drivers/mfd/ti_am335x_tscadc.c                     |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

Comments

Tony Lindgren Aug. 21, 2013, 7:58 a.m. UTC | #1
* Zubair Lutfullah <zubair.lutfullah@gmail.com> [130715 08:33]:
> Did a grep for coordiante and replaced them all
> with coordinate.
> 
> This applies to the mfd-next tree.

This should be safe to apply via the MFD tree as a non-critical
fix assuming the bootloaders are not yet using this:

Acked-by: Tony Lindgren <tony@atomide.com>

> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com>
> ---
>  .../bindings/input/touchscreen/ti-tsc-adc.txt      |    4 ++--
>  arch/arm/boot/dts/am335x-evm.dts                   |    2 +-
>  drivers/input/touchscreen/ti_am335x_tsc.c          |    2 +-
>  drivers/mfd/ti_am335x_tscadc.c                     |    2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> index 491c97b..3e22aec 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> @@ -6,7 +6,7 @@ Required properties:
>  	ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
>  		  support on the platform.
>  	ti,x-plate-resistance: X plate resistance
> -	ti,coordiante-readouts: The sequencer supports a total of 16
> +	ti,coordinate-readouts: The sequencer supports a total of 16
>  				programmable steps each step is used to
>  				read a single coordinate. A single
>                                  readout is enough but multiple reads can
> @@ -34,7 +34,7 @@ Example:
>  		tsc {
>  			ti,wires = <4>;
>  			ti,x-plate-resistance = <200>;
> -			ti,coordiante-readouts = <5>;
> +			ti,coordinate-readouts = <5>;
>  			ti,wire-config = <0x00 0x11 0x22 0x33>;
>  		};
>  
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 0fa4c7f..e50b781 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -250,7 +250,7 @@
>  	tsc {
>  		ti,wires = <4>;
>  		ti,x-plate-resistance = <200>;
> -		ti,coordiante-readouts = <5>;
> +		ti,coordinate-readouts = <5>;
>  		ti,wire-config = <0x00 0x11 0x22 0x33>;
>  	};
>  
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index 0e9f02a..6422f65 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -348,7 +348,7 @@ static int titsc_parse_dt(struct platform_device *pdev,
>  	if (err < 0)
>  		return err;
>  
> -	err = of_property_read_u32(node, "ti,coordiante-readouts",
> +	err = of_property_read_u32(node, "ti,coordinate-readouts",
>  			&ts_dev->coordinate_readouts);
>  	if (err < 0)
>  		return err;
> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> index b003a16..dd31e23 100644
> --- a/drivers/mfd/ti_am335x_tscadc.c
> +++ b/drivers/mfd/ti_am335x_tscadc.c
> @@ -106,7 +106,7 @@ static	int ti_tscadc_probe(struct platform_device *pdev)
>  
>  	node = of_get_child_by_name(pdev->dev.of_node, "tsc");
>  	of_property_read_u32(node, "ti,wires", &tsc_wires);
> -	of_property_read_u32(node, "ti,coordiante-readouts", &readouts);
> +	of_property_read_u32(node, "ti,coordinate-readouts", &readouts);
>  
>  	node = of_get_child_by_name(pdev->dev.of_node, "adc");
>  	of_property_for_each_u32(node, "ti,adc-channels", prop, cur, val) {
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Luebbe Oct. 19, 2013, 4:02 p.m. UTC | #2
On Wed, 2013-08-21 at 00:58 -0700, Tony Lindgren wrote:
> * Zubair Lutfullah <zubair.lutfullah@gmail.com> [130715 08:33]:
> > Did a grep for coordiante and replaced them all
> > with coordinate.
> > 
> > This applies to the mfd-next tree.
> 
> This should be safe to apply via the MFD tree as a non-critical
> fix assuming the bootloaders are not yet using this:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

It seems this didn't get applied. It fixes the touchscreen on a
BeagleBone black with the 7" LCD and we should avoid having people use
the wrong binding.

Samuel or Lee: Could you take this patch?

Thanks,
Jan Lübbe

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Oct. 22, 2013, 9:05 a.m. UTC | #3
On Sat, 19 Oct 2013, Jan Lübbe wrote:

> On Wed, 2013-08-21 at 00:58 -0700, Tony Lindgren wrote:
> > * Zubair Lutfullah <zubair.lutfullah@gmail.com> [130715 08:33]:
> > > Did a grep for coordiante and replaced them all
> > > with coordinate.
> > > 
> > > This applies to the mfd-next tree.
> > 
> > This should be safe to apply via the MFD tree as a non-critical
> > fix assuming the bootloaders are not yet using this:
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> It seems this didn't get applied. It fixes the touchscreen on a
> BeagleBone black with the 7" LCD and we should avoid having people use
> the wrong binding.
> 
> Samuel or Lee: Could you take this patch?

This is the first time this patch has been sent to me.

I need Dmitry's input (no pun intended) on how he's like to deal with
this. At a bare minimum I'd like his Ack.
Jan Luebbe Nov. 5, 2013, 4:01 p.m. UTC | #4
On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote:
> This is the first time this patch has been sent to me.
> 
> I need Dmitry's input (no pun intended) on how he's like to deal with
> this. At a bare minimum I'd like his Ack.

Is there anything I can do to push this forward? The earlier we get the
typo fixed in the documentation, the less chance that someone will use
it that way.

Regards,
Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Nov. 5, 2013, 5:15 p.m. UTC | #5
On Tue, 05 Nov 2013, Jan Lübbe wrote:

> On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote:
> > This is the first time this patch has been sent to me.
> > 
> > I need Dmitry's input (no pun intended) on how he's like to deal with
> > this. At a bare minimum I'd like his Ack.
> 
> Is there anything I can do to push this forward? The earlier we get the
> typo fixed in the documentation, the less chance that someone will use
> it that way.

I think you should sent it again, but this time Cc the Device Tree
list, Dmitry and myself when you submit.
Jan Luebbe Nov. 5, 2013, 5:51 p.m. UTC | #6
On Tue, 2013-11-05 at 17:15 +0000, Lee Jones wrote:
> On Tue, 05 Nov 2013, Jan Lübbe wrote:
> 
> > On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote:
> > > This is the first time this patch has been sent to me.
> > > 
> > > I need Dmitry's input (no pun intended) on how he's like to deal with
> > > this. At a bare minimum I'd like his Ack.
> > 
> > Is there anything I can do to push this forward? The earlier we get the
> > typo fixed in the documentation, the less chance that someone will use
> > it that way.
> 
> I think you should sent it again, but this time Cc the Device Tree
> list, Dmitry and myself when you submit.

The original patch was not from me. But sure, I can resend it.

Jan


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Nov. 5, 2013, 6:03 p.m. UTC | #7
On Tue, 05 Nov 2013, Jan Lübbe wrote:

> On Tue, 2013-11-05 at 17:15 +0000, Lee Jones wrote:
> > On Tue, 05 Nov 2013, Jan Lübbe wrote:
> > 
> > > On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote:
> > > > This is the first time this patch has been sent to me.
> > > > 
> > > > I need Dmitry's input (no pun intended) on how he's like to deal with
> > > > this. At a bare minimum I'd like his Ack.
> > > 
> > > Is there anything I can do to push this forward? The earlier we get the
> > > typo fixed in the documentation, the less chance that someone will use
> > > it that way.
> > 
> > I think you should sent it again, but this time Cc the Device Tree
> > list, Dmitry and myself when you submit.
> 
> The original patch was not from me. But sure, I can resend it.

I'm not worried about who re-sends the patch. Just make sure whoever
does sends in correctly with regards to the $SUBJECT line etc. The one
on this patch looks odd.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
index 491c97b..3e22aec 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
@@ -6,7 +6,7 @@  Required properties:
 	ti,wires: Wires refer to application modes i.e. 4/5/8 wire touchscreen
 		  support on the platform.
 	ti,x-plate-resistance: X plate resistance
-	ti,coordiante-readouts: The sequencer supports a total of 16
+	ti,coordinate-readouts: The sequencer supports a total of 16
 				programmable steps each step is used to
 				read a single coordinate. A single
                                 readout is enough but multiple reads can
@@ -34,7 +34,7 @@  Example:
 		tsc {
 			ti,wires = <4>;
 			ti,x-plate-resistance = <200>;
-			ti,coordiante-readouts = <5>;
+			ti,coordinate-readouts = <5>;
 			ti,wire-config = <0x00 0x11 0x22 0x33>;
 		};
 
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 0fa4c7f..e50b781 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -250,7 +250,7 @@ 
 	tsc {
 		ti,wires = <4>;
 		ti,x-plate-resistance = <200>;
-		ti,coordiante-readouts = <5>;
+		ti,coordinate-readouts = <5>;
 		ti,wire-config = <0x00 0x11 0x22 0x33>;
 	};
 
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 0e9f02a..6422f65 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -348,7 +348,7 @@  static int titsc_parse_dt(struct platform_device *pdev,
 	if (err < 0)
 		return err;
 
-	err = of_property_read_u32(node, "ti,coordiante-readouts",
+	err = of_property_read_u32(node, "ti,coordinate-readouts",
 			&ts_dev->coordinate_readouts);
 	if (err < 0)
 		return err;
diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
index b003a16..dd31e23 100644
--- a/drivers/mfd/ti_am335x_tscadc.c
+++ b/drivers/mfd/ti_am335x_tscadc.c
@@ -106,7 +106,7 @@  static	int ti_tscadc_probe(struct platform_device *pdev)
 
 	node = of_get_child_by_name(pdev->dev.of_node, "tsc");
 	of_property_read_u32(node, "ti,wires", &tsc_wires);
-	of_property_read_u32(node, "ti,coordiante-readouts", &readouts);
+	of_property_read_u32(node, "ti,coordinate-readouts", &readouts);
 
 	node = of_get_child_by_name(pdev->dev.of_node, "adc");
 	of_property_for_each_u32(node, "ti,adc-channels", prop, cur, val) {