diff mbox

hid-holtekff: don't push static constants on stack for %*ph

Message ID 1375441680-13593-1-git-send-email-andriy.shevchenko@linux.intel.com
State New, archived
Delegated to: Jiri Kosina
Headers show

Commit Message

Andy Shevchenko Aug. 2, 2013, 11:08 a.m. UTC
There is no need to pass constants via stack. The width may be explicitly
specified in the format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/hid/hid-holtekff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina Aug. 5, 2013, 9:30 a.m. UTC | #1
On Fri, 2 Aug 2013, Andy Shevchenko wrote:

> There is no need to pass constants via stack. The width may be explicitly
> specified in the format.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/hid/hid-holtekff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
> index 9a8f051..9325545 100644
> --- a/drivers/hid/hid-holtekff.c
> +++ b/drivers/hid/hid-holtekff.c
> @@ -98,7 +98,7 @@ static void holtekff_send(struct holtekff_device *holtekff,
>  		holtekff->field->value[i] = data[i];
>  	}
>  
> -	dbg_hid("sending %*ph\n", 7, data);
> +	dbg_hid("sending %7ph\n", data);
>  
>  	hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);

Applied, thanks Andy.
diff mbox

Patch

diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
index 9a8f051..9325545 100644
--- a/drivers/hid/hid-holtekff.c
+++ b/drivers/hid/hid-holtekff.c
@@ -98,7 +98,7 @@  static void holtekff_send(struct holtekff_device *holtekff,
 		holtekff->field->value[i] = data[i];
 	}
 
-	dbg_hid("sending %*ph\n", 7, data);
+	dbg_hid("sending %7ph\n", data);
 
 	hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);
 }