diff mbox

[1/1] Input: htcpen - Fix incorrect placement of __initdata

Message ID 1375868346-28851-1-git-send-email-sachin.kamat@linaro.org
State New, archived
Headers show

Commit Message

Sachin Kamat Aug. 7, 2013, 9:39 a.m. UTC
__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Pau Oliva Fora <pau@eslack.org>
---
 drivers/input/touchscreen/htcpen.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sachin Kamat Aug. 14, 2013, 6:25 a.m. UTC | #1
Hi Dmitry,

On 7 August 2013 15:09, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> __initdata should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Pau Oliva Fora <pau@eslack.org>
> ---
>  drivers/input/touchscreen/htcpen.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
> index 6c4fb84..6650085 100644
> --- a/drivers/input/touchscreen/htcpen.c
> +++ b/drivers/input/touchscreen/htcpen.c
> @@ -221,7 +221,7 @@ static struct isa_driver htcpen_isa_driver = {
>         }
>  };
>
> -static struct dmi_system_id __initdata htcshift_dmi_table[] = {
> +static struct dmi_system_id htcshift_dmi_table[] __initdata = {
>         {
>                 .ident = "Shift",
>                 .matches = {
> --
> 1.7.9.5
>

Thanks for applying my other patches. Looks like you missed this one though :)
Dmitry Torokhov Aug. 15, 2013, 6:51 a.m. UTC | #2
Hi Sachin,

On Wed, Aug 14, 2013 at 11:55:22AM +0530, Sachin Kamat wrote:
> Hi Dmitry,
> 
> On 7 August 2013 15:09, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > __initdata should be placed between the variable name and equal
> > sign for the variable to be placed in the intended section.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Cc: Pau Oliva Fora <pau@eslack.org>
> > ---
> >  drivers/input/touchscreen/htcpen.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
> > index 6c4fb84..6650085 100644
> > --- a/drivers/input/touchscreen/htcpen.c
> > +++ b/drivers/input/touchscreen/htcpen.c
> > @@ -221,7 +221,7 @@ static struct isa_driver htcpen_isa_driver = {
> >         }
> >  };
> >
> > -static struct dmi_system_id __initdata htcshift_dmi_table[] = {
> > +static struct dmi_system_id htcshift_dmi_table[] __initdata = {
> >         {
> >                 .ident = "Shift",
> >                 .matches = {
> > --
> > 1.7.9.5
> >
> 
> Thanks for applying my other patches. Looks like you missed this one though :)

Got it now, thanks.
diff mbox

Patch

diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
index 6c4fb84..6650085 100644
--- a/drivers/input/touchscreen/htcpen.c
+++ b/drivers/input/touchscreen/htcpen.c
@@ -221,7 +221,7 @@  static struct isa_driver htcpen_isa_driver = {
 	}
 };
 
-static struct dmi_system_id __initdata htcshift_dmi_table[] = {
+static struct dmi_system_id htcshift_dmi_table[] __initdata = {
 	{
 		.ident = "Shift",
 		.matches = {