diff mbox

drivers/input/misc/adxl34x: Fix bug in definition of ADXL346_2D_ORIENT

Message ID 1386588910-4604-1-git-send-email-michael.hennerich@analog.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hennerich, Michael Dec. 9, 2013, 11:35 a.m. UTC 
From: Michael Hennerich <michael.hennerich@analog.com>

Coverity report pointet out by Dmitry

Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
---
 drivers/input/misc/adxl34x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Dec. 10, 2013, 6:14 a.m. UTC | #1 
On Mon, Dec 09, 2013 at 12:35:10PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> Coverity report pointet out by Dmitry
> 
> Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>


Applied, thank you.

> ---
>  drivers/input/misc/adxl34x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
> index 0735de3..1cb1da2 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -158,7 +158,7 @@
>  
>  /* ORIENT ADXL346 only */
>  #define ADXL346_2D_VALID		(1 << 6)
> -#define ADXL346_2D_ORIENT(x)		(((x) & 0x3) >> 4)
> +#define ADXL346_2D_ORIENT(x)		(((x) & 0x30) >> 4)
>  #define ADXL346_3D_VALID		(1 << 3)
>  #define ADXL346_3D_ORIENT(x)		((x) & 0x7)
>  #define ADXL346_2D_PORTRAIT_POS		0	/* +X */
> -- 
> 1.7.9.5
> 
>
diff mbox

Patch

diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
index 0735de3..1cb1da2 100644
--- a/drivers/input/misc/adxl34x.c
+++ b/drivers/input/misc/adxl34x.c
@@ -158,7 +158,7 @@ 
 
 /* ORIENT ADXL346 only */
 #define ADXL346_2D_VALID		(1 << 6)
-#define ADXL346_2D_ORIENT(x)		(((x) & 0x3) >> 4)
+#define ADXL346_2D_ORIENT(x)		(((x) & 0x30) >> 4)
 #define ADXL346_3D_VALID		(1 << 3)
 #define ADXL346_3D_ORIENT(x)		((x) & 0x7)
 #define ADXL346_2D_PORTRAIT_POS		0	/* +X */