diff mbox

[V2] Input: define KEY_WWAN for Wireless WAN

Message ID 1386671349-16337-1-git-send-email-zajec5@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rafał Miłecki Dec. 10, 2013, 10:29 a.m. UTC
Some devices with support for mobile networks may have buttons for
enabling/disabling such connection. An example can be Linksys router
54G3G.
We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
to add KEY_WWAN as well.
As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
alias.

Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
---
 include/uapi/linux/input.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jiri Kosina Dec. 10, 2013, 7:36 p.m. UTC | #1
On Tue, 10 Dec 2013, Rafa? Mi?ecki wrote:

> Some devices with support for mobile networks may have buttons for
> enabling/disabling such connection. An example can be Linksys router
> 54G3G.
> We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
> to add KEY_WWAN as well.
> As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
> alias.
> 
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
> ---
>  include/uapi/linux/input.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a372627..7c69941 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -464,7 +464,8 @@ struct input_keymap_entry {
>  #define KEY_BRIGHTNESS_ZERO	244	/* brightness off, use ambient */
>  #define KEY_DISPLAY_OFF		245	/* display device to off state */
>  
> -#define KEY_WIMAX		246
> +#define KEY_WWAN		246	/* Wireless WAN (LTE, UMTS, GSM, etc.) */
> +#define KEY_WIMAX		KEY_WWAN
>  #define KEY_RFKILL		247	/* Key that controls all radios */
>  
>  #define KEY_MICMUTE		248	/* Mute / unmute the microphone */

Adding Dmitry to CC
Dmitry Torokhov Dec. 16, 2013, 5:02 a.m. UTC | #2
On Tue, Dec 10, 2013 at 08:36:41PM +0100, Jiri Kosina wrote:
> On Tue, 10 Dec 2013, Rafa? Mi?ecki wrote:
> 
> > Some devices with support for mobile networks may have buttons for
> > enabling/disabling such connection. An example can be Linksys router
> > 54G3G.
> > We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
> > to add KEY_WWAN as well.
> > As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
> > alias.
> > 
> > Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> > ---
> > V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
> > ---
> >  include/uapi/linux/input.h |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> > index a372627..7c69941 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -464,7 +464,8 @@ struct input_keymap_entry {
> >  #define KEY_BRIGHTNESS_ZERO	244	/* brightness off, use ambient */
> >  #define KEY_DISPLAY_OFF		245	/* display device to off state */
> >  
> > -#define KEY_WIMAX		246
> > +#define KEY_WWAN		246	/* Wireless WAN (LTE, UMTS, GSM, etc.) */
> > +#define KEY_WIMAX		KEY_WWAN
> >  #define KEY_RFKILL		247	/* Key that controls all radios */
> >  
> >  #define KEY_MICMUTE		248	/* Mute / unmute the microphone */
> 
> Adding Dmitry to CC

Applied, thank you.
diff mbox

Patch

diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index a372627..7c69941 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -464,7 +464,8 @@  struct input_keymap_entry {
 #define KEY_BRIGHTNESS_ZERO	244	/* brightness off, use ambient */
 #define KEY_DISPLAY_OFF		245	/* display device to off state */
 
-#define KEY_WIMAX		246
+#define KEY_WWAN		246	/* Wireless WAN (LTE, UMTS, GSM, etc.) */
+#define KEY_WIMAX		KEY_WWAN
 #define KEY_RFKILL		247	/* Key that controls all radios */
 
 #define KEY_MICMUTE		248	/* Mute / unmute the microphone */