| Message ID | 1392055139-19631-3-git-send-email-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > uHID is missing a SET_REPORT protocol implementation, but as > .hid_get_raw_report() as been removed from struct hid_device, > there were no means to access GET_REPORT in uhid. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/hid/uhid.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c > index b6de903..60acee4 100644 > --- a/drivers/hid/uhid.c > +++ b/drivers/hid/uhid.c > @@ -250,6 +250,21 @@ static int uhid_hid_output_report(struct hid_device *hid, __u8 *buf, > return uhid_hid_output_raw(hid, buf, count, HID_OUTPUT_REPORT); > } > > +static int uhid_raw_request(struct hid_device *hid, unsigned char reportnum, > + __u8 *buf, size_t len, unsigned char rtype, > + int reqtype) > +{ > + switch (reqtype) { > + case HID_REQ_GET_REPORT: > + return uhid_hid_get_raw(hid, reportnum, buf, len, rtype); > + case HID_REQ_SET_REPORT: > + /* TODO: implement proper SET_REPORT functionality */ > + return -ENOSYS; Looks good. I will try to implement it today and send a patch. Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Thanks David > + default: > + return -EIO; > + } > +} > + > static struct hid_ll_driver uhid_hid_driver = { > .start = uhid_hid_start, > .stop = uhid_hid_stop, > @@ -257,6 +272,7 @@ static struct hid_ll_driver uhid_hid_driver = { > .close = uhid_hid_close, > .parse = uhid_hid_parse, > .output_report = uhid_hid_output_report, > + .raw_request = uhid_raw_request, > }; > > #ifdef CONFIG_COMPAT > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index b6de903..60acee4 100644 --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c @@ -250,6 +250,21 @@ static int uhid_hid_output_report(struct hid_device *hid, __u8 *buf, return uhid_hid_output_raw(hid, buf, count, HID_OUTPUT_REPORT); } +static int uhid_raw_request(struct hid_device *hid, unsigned char reportnum, + __u8 *buf, size_t len, unsigned char rtype, + int reqtype) +{ + switch (reqtype) { + case HID_REQ_GET_REPORT: + return uhid_hid_get_raw(hid, reportnum, buf, len, rtype); + case HID_REQ_SET_REPORT: + /* TODO: implement proper SET_REPORT functionality */ + return -ENOSYS; + default: + return -EIO; + } +} + static struct hid_ll_driver uhid_hid_driver = { .start = uhid_hid_start, .stop = uhid_hid_stop, @@ -257,6 +272,7 @@ static struct hid_ll_driver uhid_hid_driver = { .close = uhid_hid_close, .parse = uhid_hid_parse, .output_report = uhid_hid_output_report, + .raw_request = uhid_raw_request, }; #ifdef CONFIG_COMPAT
uHID is missing a SET_REPORT protocol implementation, but as .hid_get_raw_report() as been removed from struct hid_device, there were no means to access GET_REPORT in uhid. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/hid/uhid.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)