From patchwork Sat Feb 15 02:59:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 3655591 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 99A4BBF13A for ; Sat, 15 Feb 2014 03:07:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CFF1220160 for ; Sat, 15 Feb 2014 03:07:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAC7D20117 for ; Sat, 15 Feb 2014 03:07:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbaBODHU (ORCPT ); Fri, 14 Feb 2014 22:07:20 -0500 Received: from mail-yk0-f175.google.com ([209.85.160.175]:39857 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbaBODHU (ORCPT ); Fri, 14 Feb 2014 22:07:20 -0500 Received: by mail-yk0-f175.google.com with SMTP id 131so25419389ykp.6 for ; Fri, 14 Feb 2014 19:07:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=0b7n2WnRBQXgRzW7YRzmvEh2RXDVD6UFBVMZ0fnfJYg=; b=oShiLSCfIycvQA0AHfdrhf+P9czCxRLcUNNsT4eoC3rleRFE/Asd2IXGPmkTPXh/8i J7VnugvgcDNA7pBuiunyUqaox1LyQpA1ucrQtDaspMs+UPYhclK9CpYSUDduShxx5Ymg aww3rwygyySAtCWx+2fxdIy6Hp7leY91FfE7MsR98MVkiFxyzn5vAv+FsP0JhghvUqwn 2EyLt3c3DpMqHKfgLTuTxrvhuSRd1A5XmMTRw7d6f6VeKtO//HcmQDj/4ojEzN6cZ9k8 8JklPUaeJRPkF9HxzRqbCyKSu71rFDS7rou1PLen9d2j9X6Ow5dDGdZ76SieW+0iZ0df iCrw== X-Received: by 10.236.148.170 with SMTP id v30mr737334yhj.100.1392433195598; Fri, 14 Feb 2014 18:59:55 -0800 (PST) Received: from localhost.localdomain ([189.5.17.129]) by mx.google.com with ESMTPSA id g26sm23514191yhk.3.2014.02.14.18.59.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 18:59:55 -0800 (PST) From: Fabio Estevam To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, Fabio Estevam Subject: [PATCH 1/2] Input: imx_keypad - Propagate the real error code on platform_get_irq() failure Date: Sat, 15 Feb 2014 00:59:46 -0200 Message-Id: <1392433187-7756-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Just return the error code itself instead. Signed-off-by: Fabio Estevam --- drivers/input/keyboard/imx_keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c index cbf4f80..de07035 100644 --- a/drivers/input/keyboard/imx_keypad.c +++ b/drivers/input/keyboard/imx_keypad.c @@ -439,7 +439,7 @@ static int imx_keypad_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { dev_err(&pdev->dev, "no irq defined in platform data\n"); - return -EINVAL; + return irq; } input_dev = devm_input_allocate_device(&pdev->dev);