| Message ID | 1395430798-25606-1-git-send-email-miletus@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Fri, Mar 21, 2014 at 3:39 PM, Yufeng Shen <miletus@chromium.org> wrote: > There is timeout error during initialization: > kernel: [ 14.167086] hid-multitouch 0003:2512:5003.0001: usb_submit_urb(ctrl) failed: -1 > kernel: [ 14.167135] hid-multitouch 0003:2512:5003.0001: timeout initializing reports > kernel: [ 14.167407] input: RNDPLUS Co., LTD PULSEIR TSR4601 as /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.3/2-1.3:1.0/input/input14 > kernel: [ 14.167975] cpufreq_interactive: monitoring input on RNDPLUS Co., LTD PULSEIR TSR4601 > kernel: [ 14.168266] hid-multitouch 0003:2512:5003.0001: input,hiddev0,hidraw1: USB HID v1.10 Mouse [RNDPLUS Co., LTD PULSEIR TSR4601] on usb-0000:00:1d.0-1.3/input0 > > Adding quirk HID_QUIRK_NO_INIT_REPORTS can solve the problem. I already asked you to test if HID_QUIRK_NO_INIT_INPUT_REPORTS was working for the same same kind of timeout (https://patchwork.kernel.org/patch/3544281/). So I am asking again: please test HID_QUIRK_NO_INIT_INPUT_REPORTS and if it works, use this quirk instead the one in this patch. This *really* matters because the quirk HID_QUIRK_NO_INIT_REPORTS does not initialize feature reports which contains important information regarding hid-multitouch. Cheers, Benjamin > > Signed-off-by: Yufeng Shen <miletus@chromium.org> > --- > drivers/hid/hid-ids.h | 5 +++++ > drivers/hid/usbhid/hid-quirks.c | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index f9304cb..772f937 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -442,6 +442,11 @@ > #define USB_DEVICE_ID_IDEACOM_IDC6650 0x6650 > #define USB_DEVICE_ID_IDEACOM_IDC6651 0x6651 > > +#define USB_VENDOR_ID_IDSPULSE 0x2512 > +#define USB_DEVICE_ID_IDSPULSE_EVIR1 0x5003 > +#define USB_DEVICE_ID_IDSPULSE_EVIR2 0x5004 > +#define USB_DEVICE_ID_IDSPULSE_EVIR3 0x5005 > + > #define USB_VENDOR_ID_ILITEK 0x222a > #define USB_DEVICE_ID_ILITEK_MULTITOUCH 0x0001 > > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c > index 0db9a67..e59ad07 100644 > --- a/drivers/hid/usbhid/hid-quirks.c > +++ b/drivers/hid/usbhid/hid-quirks.c > @@ -72,6 +72,9 @@ static const struct hid_blacklist { > { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET }, > + { USB_VENDOR_ID_IDSPULSE, USB_DEVICE_ID_IDSPULSE_EVIR1, HID_QUIRK_NO_INIT_REPORTS }, > + { USB_VENDOR_ID_IDSPULSE, USB_DEVICE_ID_IDSPULSE_EVIR2, HID_QUIRK_NO_INIT_REPORTS }, > + { USB_VENDOR_ID_IDSPULSE, USB_DEVICE_ID_IDSPULSE_EVIR3, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GX680R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE, HID_QUIRK_NO_INIT_REPORTS }, > -- > 1.9.1.423.g4596e3a > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 21, 2014 at 6:08 PM, Yufeng Shen <miletus@google.com> wrote: > > > On Fri, Mar 21, 2014 at 4:58 PM, Benjamin Tissoires > <benjamin.tissoires@gmail.com> wrote: >> >> On Fri, Mar 21, 2014 at 3:39 PM, Yufeng Shen <miletus@chromium.org> wrote: >> > There is timeout error during initialization: >> > kernel: [ 14.167086] hid-multitouch 0003:2512:5003.0001: >> > usb_submit_urb(ctrl) failed: -1 >> > kernel: [ 14.167135] hid-multitouch 0003:2512:5003.0001: timeout >> > initializing reports >> > kernel: [ 14.167407] input: RNDPLUS Co., LTD PULSEIR TSR4601 as >> > /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.3/2-1.3:1.0/input/input14 >> > kernel: [ 14.167975] cpufreq_interactive: monitoring input on RNDPLUS >> > Co., LTD PULSEIR TSR4601 >> > kernel: [ 14.168266] hid-multitouch 0003:2512:5003.0001: >> > input,hiddev0,hidraw1: USB HID v1.10 Mouse [RNDPLUS Co., LTD PULSEIR >> > TSR4601] on usb-0000:00:1d.0-1.3/input0 >> > >> > Adding quirk HID_QUIRK_NO_INIT_REPORTS can solve the problem. >> >> I already asked you to test if HID_QUIRK_NO_INIT_INPUT_REPORTS was >> working for the same same kind of timeout >> (https://patchwork.kernel.org/patch/3544281/). > > > The reason I didn't test HID_QUIRK_NO_INIT_INPUT_REPORTS was that I am > mainly > working with kernel 3.8/3.10. And HID_QUIRK_NO_INIT_INPUT_REPORTS was not > present You should consider working with an upstream kernel when sending patches. > in the kernel source. Do you have the patch set that I can port to 3.8/3.10 > kernel for testing ? git blames gives 595e9276ce68791317484ec7f0f9f2e0457c3b34, which is Linus' tree since 3.12. Cheers, Benjamin > > >> >> >> So I am asking again: please test HID_QUIRK_NO_INIT_INPUT_REPORTS and >> if it works, use this quirk instead the one in this patch. >> This *really* matters because the quirk HID_QUIRK_NO_INIT_REPORTS does >> not initialize feature reports which contains important information >> regarding hid-multitouch. >> >> Cheers, >> Benjamin >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index f9304cb..772f937 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -442,6 +442,11 @@ #define USB_DEVICE_ID_IDEACOM_IDC6650 0x6650 #define USB_DEVICE_ID_IDEACOM_IDC6651 0x6651 +#define USB_VENDOR_ID_IDSPULSE 0x2512 +#define USB_DEVICE_ID_IDSPULSE_EVIR1 0x5003 +#define USB_DEVICE_ID_IDSPULSE_EVIR2 0x5004 +#define USB_DEVICE_ID_IDSPULSE_EVIR3 0x5005 + #define USB_VENDOR_ID_ILITEK 0x222a #define USB_DEVICE_ID_ILITEK_MULTITOUCH 0x0001 diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 0db9a67..e59ad07 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -72,6 +72,9 @@ static const struct hid_blacklist { { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, { USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET }, + { USB_VENDOR_ID_IDSPULSE, USB_DEVICE_ID_IDSPULSE_EVIR1, HID_QUIRK_NO_INIT_REPORTS }, + { USB_VENDOR_ID_IDSPULSE, USB_DEVICE_ID_IDSPULSE_EVIR2, HID_QUIRK_NO_INIT_REPORTS }, + { USB_VENDOR_ID_IDSPULSE, USB_DEVICE_ID_IDSPULSE_EVIR3, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET }, { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GX680R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE, HID_QUIRK_NO_INIT_REPORTS },
There is timeout error during initialization: kernel: [ 14.167086] hid-multitouch 0003:2512:5003.0001: usb_submit_urb(ctrl) failed: -1 kernel: [ 14.167135] hid-multitouch 0003:2512:5003.0001: timeout initializing reports kernel: [ 14.167407] input: RNDPLUS Co., LTD PULSEIR TSR4601 as /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.3/2-1.3:1.0/input/input14 kernel: [ 14.167975] cpufreq_interactive: monitoring input on RNDPLUS Co., LTD PULSEIR TSR4601 kernel: [ 14.168266] hid-multitouch 0003:2512:5003.0001: input,hiddev0,hidraw1: USB HID v1.10 Mouse [RNDPLUS Co., LTD PULSEIR TSR4601] on usb-0000:00:1d.0-1.3/input0 Adding quirk HID_QUIRK_NO_INIT_REPORTS can solve the problem. Signed-off-by: Yufeng Shen <miletus@chromium.org> --- drivers/hid/hid-ids.h | 5 +++++ drivers/hid/usbhid/hid-quirks.c | 3 +++ 2 files changed, 8 insertions(+)