| Message ID | 1396631237-11813-1-git-send-email-tolga@cevel.net (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Fri, Apr 4, 2014 at 1:07 PM, Tolga Cakir <tolga@cevel.net> wrote: > This is inspired by various other hid drivers. > > Signed-off-by: Tolga Cakir <tolga@cevel.net> > --- > drivers/hid/hid-microsoft.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c > index 5674c0c..5281d2d 100644 > --- a/drivers/hid/hid-microsoft.c > +++ b/drivers/hid/hid-microsoft.c > @@ -211,6 +211,8 @@ static int ms_sidewinder_kb_quirk(struct hid_input *hi, struct hid_usage *usage, > return 1; > } > > +#undef ms_map_key_clear > + Not sure this is really needed. The macro is prefixed by ms_, so I will simply let it there. Cheers, Benjamin > static int ms_sidewinder_control(struct hid_device *hdev, __u8 setup) > { > struct ms_data *sc = hid_get_drvdata(hdev); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 09.04.2014 22:42, schrieb Benjamin Tissoires: > On Fri, Apr 4, 2014 at 1:07 PM, Tolga Cakir <tolga@cevel.net> wrote: >> This is inspired by various other hid drivers. >> >> Signed-off-by: Tolga Cakir <tolga@cevel.net> >> --- >> drivers/hid/hid-microsoft.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c >> index 5674c0c..5281d2d 100644 >> --- a/drivers/hid/hid-microsoft.c >> +++ b/drivers/hid/hid-microsoft.c >> @@ -211,6 +211,8 @@ static int ms_sidewinder_kb_quirk(struct hid_input *hi, struct hid_usage *usage, >> return 1; >> } >> >> +#undef ms_map_key_clear >> + > Not sure this is really needed. The macro is prefixed by ms_, so I > will simply let it there. > > Cheers, > Benjamin Ouch, I've just rechecked hid-lenovo-tpkbd.c and it wasn't prefixed there and therefore needed. My fault, I'm sorry. Greetings, Tolga Cakir >> static int ms_sidewinder_control(struct hid_device *hdev, __u8 setup) >> { >> struct ms_data *sc = hid_get_drvdata(hdev); >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-input" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c index 5674c0c..5281d2d 100644 --- a/drivers/hid/hid-microsoft.c +++ b/drivers/hid/hid-microsoft.c @@ -211,6 +211,8 @@ static int ms_sidewinder_kb_quirk(struct hid_input *hi, struct hid_usage *usage, return 1; } +#undef ms_map_key_clear + static int ms_sidewinder_control(struct hid_device *hdev, __u8 setup) { struct ms_data *sc = hid_get_drvdata(hdev);
This is inspired by various other hid drivers. Signed-off-by: Tolga Cakir <tolga@cevel.net> --- drivers/hid/hid-microsoft.c | 2 ++ 1 file changed, 2 insertions(+)