| Message ID | 1397052181-22768-2-git-send-email-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Hans, On Wed, Apr 09, 2014 at 04:02:59PM +0200, Hans de Goede wrote: > Serio device drivers need access to the pnp_id of the serio port, windows > drivers bind by the pnp-id and some drivers need to know the exact pnp-id > used so they know exactly with which hardware model / revision they are > dealing with. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > include/linux/serio.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/serio.h b/include/linux/serio.h > index 9f779c7..6532440 100644 > --- a/include/linux/serio.h > +++ b/include/linux/serio.h > @@ -16,6 +16,7 @@ > #include <linux/mutex.h> > #include <linux/device.h> > #include <linux/mod_devicetable.h> > +#include <linux/pnp.h> > #include <uapi/linux/serio.h> > > struct serio { > @@ -28,6 +29,7 @@ struct serio { > bool manual_bind; > > struct serio_device_id id; > + struct pnp_id *pnp_id; Why do we need this if we are already adding generic 'firmware_id' attribute? Thanks.
Hi, On 04/09/2014 08:06 PM, Dmitry Torokhov wrote: > Hi Hans, > > On Wed, Apr 09, 2014 at 04:02:59PM +0200, Hans de Goede wrote: >> Serio device drivers need access to the pnp_id of the serio port, windows >> drivers bind by the pnp-id and some drivers need to know the exact pnp-id >> used so they know exactly with which hardware model / revision they are >> dealing with. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> include/linux/serio.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/serio.h b/include/linux/serio.h >> index 9f779c7..6532440 100644 >> --- a/include/linux/serio.h >> +++ b/include/linux/serio.h >> @@ -16,6 +16,7 @@ >> #include <linux/mutex.h> >> #include <linux/device.h> >> #include <linux/mod_devicetable.h> >> +#include <linux/pnp.h> >> #include <uapi/linux/serio.h> >> >> struct serio { >> @@ -28,6 +29,7 @@ struct serio { >> bool manual_bind; >> >> struct serio_device_id id; >> + struct pnp_id *pnp_id; > > Why do we need this if we are already adding generic 'firmware_id' > attribute? In patch 4/4 we do pnp-id matching in synaptics.c to set the new INPUT_PROP_TOPBUTTONPAD property on relevant touchpads. Since the kernel has a special pnp_id type + pnp_id matching code, the correct thing to do is to use that for in kernel pnp-id matching, which means that we need to propagate the pnp-id to the serio drivers. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 10, 2014 at 10:03:21AM +0200, Hans de Goede wrote: > Hi, > > On 04/09/2014 08:06 PM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Wed, Apr 09, 2014 at 04:02:59PM +0200, Hans de Goede wrote: > >> Serio device drivers need access to the pnp_id of the serio port, windows > >> drivers bind by the pnp-id and some drivers need to know the exact pnp-id > >> used so they know exactly with which hardware model / revision they are > >> dealing with. > >> > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >> --- > >> include/linux/serio.h | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/include/linux/serio.h b/include/linux/serio.h > >> index 9f779c7..6532440 100644 > >> --- a/include/linux/serio.h > >> +++ b/include/linux/serio.h > >> @@ -16,6 +16,7 @@ > >> #include <linux/mutex.h> > >> #include <linux/device.h> > >> #include <linux/mod_devicetable.h> > >> +#include <linux/pnp.h> > >> #include <uapi/linux/serio.h> > >> > >> struct serio { > >> @@ -28,6 +29,7 @@ struct serio { > >> bool manual_bind; > >> > >> struct serio_device_id id; > >> + struct pnp_id *pnp_id; > > > > Why do we need this if we are already adding generic 'firmware_id' > > attribute? > > In patch 4/4 we do pnp-id matching in synaptics.c to set the new > INPUT_PROP_TOPBUTTONPAD property on relevant touchpads. Since the kernel > has a special pnp_id type + pnp_id matching code, the correct thing to > do is to use that for in kernel pnp-id matching, which means that we > need to propagate the pnp-id to the serio drivers. I disagree that it is good enough reason for putting platform-specific data in a generic structure. If you really want to use generic PNP matching code you can just convert firmware_id back to pnp_id in Synaptics driver. Thanks.
diff --git a/include/linux/serio.h b/include/linux/serio.h index 9f779c7..6532440 100644 --- a/include/linux/serio.h +++ b/include/linux/serio.h @@ -16,6 +16,7 @@ #include <linux/mutex.h> #include <linux/device.h> #include <linux/mod_devicetable.h> +#include <linux/pnp.h> #include <uapi/linux/serio.h> struct serio { @@ -28,6 +29,7 @@ struct serio { bool manual_bind; struct serio_device_id id; + struct pnp_id *pnp_id; spinlock_t lock; /* protects critical sections from port's interrupt handler */
Serio device drivers need access to the pnp_id of the serio port, windows drivers bind by the pnp-id and some drivers need to know the exact pnp-id used so they know exactly with which hardware model / revision they are dealing with. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- include/linux/serio.h | 2 ++ 1 file changed, 2 insertions(+)