From patchwork Wed Apr 9 15:01:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Tissoires X-Patchwork-Id: 3956041 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F8D19F371 for ; Wed, 9 Apr 2014 15:02:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 09579205C7 for ; Wed, 9 Apr 2014 15:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 122E5205C1 for ; Wed, 9 Apr 2014 15:02:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933393AbaDIPBl (ORCPT ); Wed, 9 Apr 2014 11:01:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21684 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933291AbaDIPBk (ORCPT ); Wed, 9 Apr 2014 11:01:40 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s39F1Z78016894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Apr 2014 11:01:35 -0400 Received: from plouf.redhat.com (ovpn-113-139.phx2.redhat.com [10.3.113.139]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s39F1YYP019313; Wed, 9 Apr 2014 11:01:35 -0400 From: Benjamin Tissoires To: Andrew Duggan , Christopher Heiny , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: rmi: do not stop the device at the end of probe Date: Wed, 9 Apr 2014 11:01:34 -0400 Message-Id: <1397055694-6312-1-git-send-email-benjamin.tissoires@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Well, this is embarrassing, if the device is stopped at the end of probe, we get into big troubles (it even oopses my kernel). This was a leftover of an attempt to be smart when sending the patch, I deeply apologies. Signed-off-by: Benjamin Tissoires --- Hi Jiri, well, first thanks for having integrating hid-rmi in your for 3.16 branch. While backporting it to 3.13 so Fedora can get it, I noticed a tiny difference (besides formatting) between the version I submitted and the one I asked people to test... ...facepalm. Cheers, Benjamin drivers/hid/hid-rmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 699d631..7da9509 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -848,7 +848,6 @@ static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id) return -EIO; } - hid_hw_stop(hdev); return 0; }