From patchwork Sat Apr 26 15:02:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Michal_Mal=C3=BD?= X-Patchwork-Id: 4069151 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BACE1BFF02 for ; Sat, 26 Apr 2014 15:16:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0E1422026C for ; Sat, 26 Apr 2014 15:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29A8C20254 for ; Sat, 26 Apr 2014 15:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbaDZPPr (ORCPT ); Sat, 26 Apr 2014 11:15:47 -0400 Received: from smtp.devoid-pointer.net ([31.31.77.140]:50049 "EHLO smtp.devoid-pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbaDZPDw (ORCPT ); Sat, 26 Apr 2014 11:03:52 -0400 Received: from localhost.localdomain (cst-prg-12-245.cust.vodafone.cz [46.135.12.245]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by smtp.devoid-pointer.net (Postfix) with ESMTPSA id C26A120BD2; Sat, 26 Apr 2014 17:03:46 +0200 (CEST) From: =?UTF-8?q?Michal=20Mal=C3=BD?= To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz, elias.vds@gmail.com, anssi.hannula@iki.fi, simon@mungewell.org, =?UTF-8?q?Michal=20Mal=C3=BD?= Subject: [PATCH v4 22/24] hid: Port hid-lg2ff to ff-memless-next Date: Sat, 26 Apr 2014 17:02:21 +0200 Message-Id: <1398524543-15012-23-git-send-email-madcatxster@devoid-pointer.net> X-Mailer: git-send-email 1.9.2 In-Reply-To: <1398524543-15012-1-git-send-email-madcatxster@devoid-pointer.net> References: <1398524543-15012-1-git-send-email-madcatxster@devoid-pointer.net> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Port hid-lg2ff to ff-memless-next - Clamp vibration magnitude to range <0x02; 0xfd> to prevent irregular shaking of the vibration motors. Signed-off-by: Elias Vanderstuyft --- drivers/hid/Kconfig | 2 +- drivers/hid/hid-lg2ff.c | 65 ++++++++++++++++++++++++++++++++++--------------- 2 files changed, 47 insertions(+), 20 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 97d2d8f..5e70519 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -381,7 +381,7 @@ config LOGITECH_FF config LOGIRUMBLEPAD2_FF bool "Logitech force feedback support (variant 2)" depends on HID_LOGITECH - select INPUT_FF_MEMLESS + select INPUT_FF_MEMLESS_NEXT help Say Y here if you want to enable force feedback support for: - Logitech RumblePad diff --git a/drivers/hid/hid-lg2ff.c b/drivers/hid/hid-lg2ff.c index 0e3fb1a..6ab5327 100644 --- a/drivers/hid/hid-lg2ff.c +++ b/drivers/hid/hid-lg2ff.c @@ -22,42 +22,69 @@ #include +#include #include #include #include "hid-lg.h" +#define FF_UPDATE_RATE 8 + struct lg2ff_device { struct hid_report *report; }; -static int play_effect(struct input_dev *dev, void *data, - struct ff_effect *effect) +static int hid_lg2ff_start_rumble(struct hid_device *hid, struct hid_report *report, + const struct mlnx_rumble_force *rumble) { - struct hid_device *hid = input_get_drvdata(dev); - struct lg2ff_device *lg2ff = data; int weak, strong; - strong = effect->u.rumble.strong_magnitude; - weak = effect->u.rumble.weak_magnitude; +#define CLAMP_QUIRK(x) do { if (x < 2) x = 2; else if (x > 0xfd) x = 0xfd; } \ + while (0) - if (weak || strong) { - weak = weak * 0xff / 0xffff; - strong = strong * 0xff / 0xffff; + /* Scale down from MLNX range */ + strong = rumble->strong * 0xff / 0xffff; + weak = rumble->weak * 0xff / 0xffff; + CLAMP_QUIRK(weak); + CLAMP_QUIRK(strong); - lg2ff->report->field[0]->value[0] = 0x51; - lg2ff->report->field[0]->value[2] = weak; - lg2ff->report->field[0]->value[4] = strong; - } else { - lg2ff->report->field[0]->value[0] = 0xf3; - lg2ff->report->field[0]->value[2] = 0x00; - lg2ff->report->field[0]->value[4] = 0x00; - } + report->field[0]->value[0] = 0x51; + report->field[0]->value[2] = weak; + report->field[0]->value[4] = strong; - hid_hw_request(hid, lg2ff->report, HID_REQ_SET_REPORT); + hid_hw_request(hid, report, HID_REQ_SET_REPORT); return 0; } +static int hid_lg2ff_stop_rumble(struct hid_device *hid, struct hid_report *report) +{ + report->field[0]->value[0] = 0xf3; + report->field[0]->value[2] = 0x00; + report->field[0]->value[4] = 0x00; + + hid_hw_request(hid, report, HID_REQ_SET_REPORT); + return 0; +} + +static int hid_lg2ff_control(struct input_dev *dev, void *data, + const struct mlnx_effect_command *command) +{ + struct hid_device *hid = input_get_drvdata(dev); + struct lg2ff_device *lg2ff = data; + + switch (command->cmd) { + case MLNX_START_RUMBLE: + return hid_lg2ff_start_rumble(hid, lg2ff->report, &command->u.rumble_force); + break; + case MLNX_STOP_RUMBLE: + return hid_lg2ff_stop_rumble(hid, lg2ff->report); + break; + default: + dbg_hid("Unsupported effect command"); + return -EINVAL; + } +} + int lg2ff_init(struct hid_device *hid) { struct lg2ff_device *lg2ff; @@ -78,7 +105,7 @@ int lg2ff_init(struct hid_device *hid) set_bit(FF_RUMBLE, dev->ffbit); - error = input_ff_create_memless(dev, lg2ff, play_effect); + error = input_ff_create_mlnx(dev, lg2ff, hid_lg2ff_control, FF_UPDATE_RATE); if (error) { kfree(lg2ff); return error;