diff mbox

[v6,3/7] mfd: AXP20x: Add bindings documentation

Message ID 1400528868-5971-4-git-send-email-carlo@caione.org (mailing list archive)
State New, archived
Headers show

Commit Message

Carlo Caione May 19, 2014, 7:47 p.m. UTC 
Bindings documentation for the AXP20x driver. In this file also
sub-nodes are documented.

Signed-off-by: Carlo Caione <carlo@caione.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 Documentation/devicetree/bindings/mfd/axp20x.txt | 93 ++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt

Comments

Boris BREZILLON June 17, 2014, 7:24 a.m. UTC | #1 
Hello,

On 19/05/2014 21:47, Carlo Caione wrote:
> Bindings documentation for the AXP20x driver. In this file also
> sub-nodes are documented.

I think this patch has been forgotten (I didn't find it in linus' tree
or linux-next tree).

Best Regards,

Boris

>
> Signed-off-by: Carlo Caione <carlo@caione.org>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/mfd/axp20x.txt | 93 ++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> new file mode 100644
> index 0000000..cc9e01b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> @@ -0,0 +1,93 @@
> +AXP202/AXP209 device tree bindings
> +
> +The axp20x family current members :-
> +axp202 (X-Powers)
> +axp209 (X-Powers)
> +
> +Required properties:
> +- compatible: "x-powers,axp202" or "x-powers,axp209"
> +- reg: The I2C slave address for the AXP chip
> +- interrupt-parent: The parent interrupt controller
> +- interrupts: Interrupt specifiers for interrupt sources
> +- interrupt-controller: axp20x has its own internal IRQs
> +- #interrupt-cells: Should be set to 1
> +- acin-supply: The input supply for LDO1
> +- vin2-supply: The input supply for DCDC2
> +- vin3-supply: The input supply for DCDC3
> +- ldo24in-supply: The input supply for LDO2, LDO4
> +- ldo3in-supply: The input supply for LDO3
> +- ldo5in-supply: The input supply for LDO5
> +
> +- regulators: A node that houses a sub-node for each regulator. The regulators are
> +	      bound using their name as listed here: dcdc2, dcdc3, ldo1, ldo2,
> +	      ldo3, ldo4, ldo5.  The bindings details of individual regulator
> +	      device can be found in:
> +	      Documentation/devicetree/bindings/regulator/regulator.txt with
> +	      the exception of x-powers,dcdc-freq
> +- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
> +		      (range: 750-1875). Default: 1.5MHz
> +
> +Optional properties for DCDCs:
> +- x-powers,dcdc-workmode: 1 for PWM mode, 0 for AUTO mode
> +			  Default: AUTO mode
> +
> +Example:
> +
> +axp209: pmic@34 {
> +	compatible = "x-powers,axp209";
> +	reg = <0x34>;
> +	interrupt-parent = <&nmi_intc>;
> +	interrupts = <0 8>;
> +
> +	interrupt-controller;
> +	#interrupt-cells = <1>;
> +
> +	acin-supply = <&axp_ipsout_reg>;
> +	vin2-supply = <&axp_ipsout_reg>;
> +	vin3-supply = <&axp_ipsout_reg>;
> +	ldo24in-supply = <&axp_ipsout_reg>;
> +	ldo3in-supply = <&axp_ipsout_reg>;
> +	ldo5in-supply = <&axp_ipsout_reg>;
> +
> +	regulators {
> +		x-powers,dcdc-freq = <1500>;
> +
> +		axp_vcore_reg: dcdc2 {
> +			regulator-min-microvolt = <700000>;
> +			regulator-max-microvolt = <2275000>;
> +			regulator-always-on;
> +		};
> +
> +		axp_ddr_reg: dcdc3 {
> +			regulator-min-microvolt = <700000>;
> +			regulator-max-microvolt = <3500000>;
> +			regulator-always-on;
> +		};
> +
> +		axp_rtc_reg: ldo1 {
> +			regulator-always-on;
> +		};
> +
> +		axp_analog_reg: ldo2 {
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <3300000>;
> +			regulator-always-on;
> +		};
> +
> +		axp_pll_reg: ldo3 {
> +			regulator-min-microvolt = <700000>;
> +			regulator-max-microvolt = <3500000>;
> +		};
> +
> +		axp_hdmi_reg: ldo4 {
> +			regulator-min-microvolt = <1250000>;
> +			regulator-max-microvolt = <3300000>;
> +		};
> +
> +		axp_mic_reg: ldo5 {
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <3300000>;
> +		};
> +	};
> +};
> +
Lee Jones June 18, 2014, 9:06 a.m. UTC | #2 
> On 19/05/2014 21:47, Carlo Caione wrote:
> > Bindings documentation for the AXP20x driver. In this file also
> > sub-nodes are documented.
> 
> I think this patch has been forgotten (I didn't find it in linus' tree
> or linux-next tree).

This patch-set became confusing.  Some of the patches were applied in
v5 and were still submitted for v6.  I need Carlo to rebase on top of
v3.16-rc1+ and re-submit with the Acks he's collected so far.

> > Signed-off-by: Carlo Caione <carlo@caione.org>
> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/axp20x.txt | 93 ++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> > new file mode 100644
> > index 0000000..cc9e01b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> > @@ -0,0 +1,93 @@
> > +AXP202/AXP209 device tree bindings
> > +
> > +The axp20x family current members :-
> > +axp202 (X-Powers)
> > +axp209 (X-Powers)
> > +
> > +Required properties:
> > +- compatible: "x-powers,axp202" or "x-powers,axp209"
> > +- reg: The I2C slave address for the AXP chip
> > +- interrupt-parent: The parent interrupt controller
> > +- interrupts: Interrupt specifiers for interrupt sources
> > +- interrupt-controller: axp20x has its own internal IRQs
> > +- #interrupt-cells: Should be set to 1
> > +- acin-supply: The input supply for LDO1
> > +- vin2-supply: The input supply for DCDC2
> > +- vin3-supply: The input supply for DCDC3
> > +- ldo24in-supply: The input supply for LDO2, LDO4
> > +- ldo3in-supply: The input supply for LDO3
> > +- ldo5in-supply: The input supply for LDO5
> > +
> > +- regulators: A node that houses a sub-node for each regulator. The regulators are
> > +	      bound using their name as listed here: dcdc2, dcdc3, ldo1, ldo2,
> > +	      ldo3, ldo4, ldo5.  The bindings details of individual regulator
> > +	      device can be found in:
> > +	      Documentation/devicetree/bindings/regulator/regulator.txt with
> > +	      the exception of x-powers,dcdc-freq
> > +- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
> > +		      (range: 750-1875). Default: 1.5MHz
> > +
> > +Optional properties for DCDCs:
> > +- x-powers,dcdc-workmode: 1 for PWM mode, 0 for AUTO mode
> > +			  Default: AUTO mode
> > +
> > +Example:
> > +
> > +axp209: pmic@34 {
> > +	compatible = "x-powers,axp209";
> > +	reg = <0x34>;
> > +	interrupt-parent = <&nmi_intc>;
> > +	interrupts = <0 8>;
> > +
> > +	interrupt-controller;
> > +	#interrupt-cells = <1>;
> > +
> > +	acin-supply = <&axp_ipsout_reg>;
> > +	vin2-supply = <&axp_ipsout_reg>;
> > +	vin3-supply = <&axp_ipsout_reg>;
> > +	ldo24in-supply = <&axp_ipsout_reg>;
> > +	ldo3in-supply = <&axp_ipsout_reg>;
> > +	ldo5in-supply = <&axp_ipsout_reg>;
> > +
> > +	regulators {
> > +		x-powers,dcdc-freq = <1500>;
> > +
> > +		axp_vcore_reg: dcdc2 {
> > +			regulator-min-microvolt = <700000>;
> > +			regulator-max-microvolt = <2275000>;
> > +			regulator-always-on;
> > +		};
> > +
> > +		axp_ddr_reg: dcdc3 {
> > +			regulator-min-microvolt = <700000>;
> > +			regulator-max-microvolt = <3500000>;
> > +			regulator-always-on;
> > +		};
> > +
> > +		axp_rtc_reg: ldo1 {
> > +			regulator-always-on;
> > +		};
> > +
> > +		axp_analog_reg: ldo2 {
> > +			regulator-min-microvolt = <1800000>;
> > +			regulator-max-microvolt = <3300000>;
> > +			regulator-always-on;
> > +		};
> > +
> > +		axp_pll_reg: ldo3 {
> > +			regulator-min-microvolt = <700000>;
> > +			regulator-max-microvolt = <3500000>;
> > +		};
> > +
> > +		axp_hdmi_reg: ldo4 {
> > +			regulator-min-microvolt = <1250000>;
> > +			regulator-max-microvolt = <3300000>;
> > +		};
> > +
> > +		axp_mic_reg: ldo5 {
> > +			regulator-min-microvolt = <1800000>;
> > +			regulator-max-microvolt = <3300000>;
> > +		};
> > +	};
> > +};
> > +
>
Carlo Caione June 21, 2014, 8:52 a.m. UTC | #3 
On Wed, Jun 18, 2014 at 11:06 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> On 19/05/2014 21:47, Carlo Caione wrote:
>> > Bindings documentation for the AXP20x driver. In this file also
>> > sub-nodes are documented.
>>
>> I think this patch has been forgotten (I didn't find it in linus' tree
>> or linux-next tree).
>
> This patch-set became confusing.  Some of the patches were applied in
> v5 and were still submitted for v6.  I need Carlo to rebase on top of
> v3.16-rc1+ and re-submit with the Acks he's collected so far.

I'm confused too. At the time of the submission v6 was already the
patchset without the patches from v5 already applied and v6 already
contains all the ACKs I have collected (i.e. the input/misc driver has
been already ack-ed by Dmitry, yet it seems not merged).
So what exactly do you want me to resubmit? The whole v6 on top of v3.16-rc1+?
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
new file mode 100644
index 0000000..cc9e01b
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
@@ -0,0 +1,93 @@ 
+AXP202/AXP209 device tree bindings
+
+The axp20x family current members :-
+axp202 (X-Powers)
+axp209 (X-Powers)
+
+Required properties:
+- compatible: "x-powers,axp202" or "x-powers,axp209"
+- reg: The I2C slave address for the AXP chip
+- interrupt-parent: The parent interrupt controller
+- interrupts: Interrupt specifiers for interrupt sources
+- interrupt-controller: axp20x has its own internal IRQs
+- #interrupt-cells: Should be set to 1
+- acin-supply: The input supply for LDO1
+- vin2-supply: The input supply for DCDC2
+- vin3-supply: The input supply for DCDC3
+- ldo24in-supply: The input supply for LDO2, LDO4
+- ldo3in-supply: The input supply for LDO3
+- ldo5in-supply: The input supply for LDO5
+
+- regulators: A node that houses a sub-node for each regulator. The regulators are
+	      bound using their name as listed here: dcdc2, dcdc3, ldo1, ldo2,
+	      ldo3, ldo4, ldo5.  The bindings details of individual regulator
+	      device can be found in:
+	      Documentation/devicetree/bindings/regulator/regulator.txt with
+	      the exception of x-powers,dcdc-freq
+- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
+		      (range: 750-1875). Default: 1.5MHz
+
+Optional properties for DCDCs:
+- x-powers,dcdc-workmode: 1 for PWM mode, 0 for AUTO mode
+			  Default: AUTO mode
+
+Example:
+
+axp209: pmic@34 {
+	compatible = "x-powers,axp209";
+	reg = <0x34>;
+	interrupt-parent = <&nmi_intc>;
+	interrupts = <0 8>;
+
+	interrupt-controller;
+	#interrupt-cells = <1>;
+
+	acin-supply = <&axp_ipsout_reg>;
+	vin2-supply = <&axp_ipsout_reg>;
+	vin3-supply = <&axp_ipsout_reg>;
+	ldo24in-supply = <&axp_ipsout_reg>;
+	ldo3in-supply = <&axp_ipsout_reg>;
+	ldo5in-supply = <&axp_ipsout_reg>;
+
+	regulators {
+		x-powers,dcdc-freq = <1500>;
+
+		axp_vcore_reg: dcdc2 {
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <2275000>;
+			regulator-always-on;
+		};
+
+		axp_ddr_reg: dcdc3 {
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <3500000>;
+			regulator-always-on;
+		};
+
+		axp_rtc_reg: ldo1 {
+			regulator-always-on;
+		};
+
+		axp_analog_reg: ldo2 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <3300000>;
+			regulator-always-on;
+		};
+
+		axp_pll_reg: ldo3 {
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <3500000>;
+		};
+
+		axp_hdmi_reg: ldo4 {
+			regulator-min-microvolt = <1250000>;
+			regulator-max-microvolt = <3300000>;
+		};
+
+		axp_mic_reg: ldo5 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <3300000>;
+		};
+	};
+};
+