From patchwork Mon Sep 15 17:55:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 4907061 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5E3FD9F349 for ; Mon, 15 Sep 2014 17:54:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ADD3620218 for ; Mon, 15 Sep 2014 17:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85DE52015D for ; Mon, 15 Sep 2014 17:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754040AbaIOR4x (ORCPT ); Mon, 15 Sep 2014 13:56:53 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:57125 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348AbaIOR4w (ORCPT ); Mon, 15 Sep 2014 13:56:52 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8FHuGO7002005; Mon, 15 Sep 2014 12:56:16 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8FHuGI2020373; Mon, 15 Sep 2014 12:56:16 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Mon, 15 Sep 2014 12:56:15 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8FHuFP6008070; Mon, 15 Sep 2014 12:56:15 -0500 From: Nishanth Menon To: Dmitry Torokhov CC: , , , , , Nishanth Menon , Julia Lawal , Dan Carpenter Subject: [PATCH] Input: palmas-pwrbutton: Fix IRQ flags for using threaded handler alone. Date: Mon, 15 Sep 2014 12:55:58 -0500 Message-ID: <1410803758-26906-1-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o Reports: drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Palmas powerbutton just needs threaded IRQ handler since I2C operations are involved and there is nothing in non-threaded primary handler we could do. So mark the request with ONESHOT as it should have been done in these cases. Cc: Julia Lawal Cc: Dan Carpenter Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton") Reported-by: kbuild test robot Signed-off-by: Nishanth Menon --- drivers/input/misc/palmas-pwrbutton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c index 4ed6f78..c0c4636 100644 --- a/drivers/input/misc/palmas-pwrbutton.c +++ b/drivers/input/misc/palmas-pwrbutton.c @@ -211,8 +211,8 @@ static int palmas_pwron_probe(struct platform_device *pdev) pwron->irq = platform_get_irq(pdev, 0); error = request_threaded_irq(pwron->irq, NULL, pwron_irq, - IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW, - dev_name(dev), pwron); + IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW | + IRQF_ONESHOT, dev_name(dev), pwron); if (error) { dev_err(dev, "Can't get IRQ for pwron: %d\n", error); goto err_free_input;