From patchwork Mon Nov 3 08:32:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dudley Du X-Patchwork-Id: 5215011 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0F27D9F295 for ; Mon, 3 Nov 2014 08:39:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0EB0B20173 for ; Mon, 3 Nov 2014 08:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8FEF20166 for ; Mon, 3 Nov 2014 08:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbaKCIfh (ORCPT ); Mon, 3 Nov 2014 03:35:37 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:51756 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbaKCIff (ORCPT ); Mon, 3 Nov 2014 03:35:35 -0500 Received: by mail-pd0-f170.google.com with SMTP id z10so11102537pdj.15 for ; Mon, 03 Nov 2014 00:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=08LtXT5UeqSfwAXjzXbPKDwQORrdWdxaLe/NCZBEKz8=; b=R/IGGt6+r2PempFb5AMsPXmujPK53a5Sn1YZ78G8MfAwrklkoiQpKibJTGKWPCKMgS 2/aHwEG8sAB7UIuOyXHtmBe35gTSOtzrWmCm19RmFdIP8SXsy4OtMhOt3K84csvkMD08 2bZCVTSgRSASNEzBIrjAV8OdZbb9NZrjlWlgZegBdgKNAWbyR2cs5N/LkdCDgrqoc/BE +DD0yCf5zXQGne7zNyZlzS8jnHDsCTwHjLKAhscm9MQCKiqU+0kAP6PLXrFe5zbRl/WH KJd1On6Yy0CCpZzJyvwQEpQQOsKz+sMYe9Yr86oVrgbTPZGcChYUV9SDG3ZmiFirbK9N 2mQg== X-Received: by 10.68.68.235 with SMTP id z11mr41209248pbt.102.1415003734786; Mon, 03 Nov 2014 00:35:34 -0800 (PST) Received: from localhost ([140.207.206.26]) by mx.google.com with ESMTPSA id f12sm16549549pat.46.2014.11.03.00.35.31 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 03 Nov 2014 00:35:33 -0800 (PST) From: Dudley Du X-Google-Original-From: Dudley Du To: dmitry.torokhov@gmail.com, rydberg@euromail.se Cc: Dudley Du , bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 06/18] input: cyapa: add runtime power management interfaces supported for the device Date: Mon, 3 Nov 2014 16:32:58 +0800 Message-Id: <1415003590-30485-7-git-send-email-dudl@cypress.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1415003590-30485-1-git-send-email-dudl@cypress.com> References: <1415003590-30485-1-git-send-email-dudl@cypress.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add runtime_suspend_scanrate_ms power management interfaces in device's power group, so users or applications can control the runtime power management strategy of trackpad device as their requirements. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.c | 168 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 168 insertions(+) diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index 420696d..d4b7c42 100644 --- a/drivers/input/mouse/cyapa.c +++ b/drivers/input/mouse/cyapa.c @@ -23,6 +23,7 @@ #include #include #include +#include #include "cyapa.h" @@ -259,6 +260,7 @@ static irqreturn_t cyapa_irq(int irq, void *dev_id) bool cont; int ret; + pm_runtime_get_sync(dev); if (device_may_wakeup(dev)) pm_wakeup_event(dev, 0); @@ -282,6 +284,8 @@ static irqreturn_t cyapa_irq(int irq, void *dev_id) } out: + pm_runtime_mark_last_busy(dev); + pm_runtime_put_sync_autosuspend(dev); return IRQ_HANDLED; } @@ -595,6 +599,116 @@ static void cyapa_remove_power_wakeup_group(void *data) } #endif /* CONFIG_PM_SLEEP */ +#ifdef CONFIG_PM_RUNTIME +static ssize_t cyapa_show_rt_suspend_scanrate(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct cyapa *cyapa = dev_get_drvdata(dev); + u8 pwr_cmd; + u16 sleep_time; + int ret; + + ret = mutex_lock_interruptible(&cyapa->state_sync_lock); + if (ret) + return ret; + pwr_cmd = cyapa->runtime_suspend_power_mode; + sleep_time = cyapa->runtime_suspend_sleep_time; + mutex_unlock(&cyapa->state_sync_lock); + + if (cyapa->gen == CYAPA_GEN3) + return scnprintf(buf, PAGE_SIZE, "%u\n", + cyapa_pwr_cmd_to_sleep_time(pwr_cmd)); + return scnprintf(buf, PAGE_SIZE, "%u\n", sleep_time); +} + +static ssize_t cyapa_update_rt_suspend_scanrate(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct cyapa *cyapa = dev_get_drvdata(dev); + u16 time; + int ret; + + if (buf == NULL || count == 0 || kstrtou16(buf, 10, &time)) { + dev_err(dev, "invalid runtime suspend scanrate ms parameter\n"); + return -EINVAL; + } + + /* + * When the suspend scanrate is changed, pm_runtime_get to resume + * a potentially suspended device, update to the new pwr_cmd + * and then pm_runtime_put to suspend into the new power mode. + */ + pm_runtime_get_sync(dev); + ret = mutex_lock_interruptible(&cyapa->state_sync_lock); + if (ret) + return ret; + cyapa->runtime_suspend_sleep_time = cyapa_clamp_sleep_time(time); + cyapa->runtime_suspend_power_mode = + cyapa_sleep_time_to_pwr_cmd(cyapa->runtime_suspend_sleep_time); + mutex_unlock(&cyapa->state_sync_lock); + pm_runtime_put_sync_autosuspend(dev); + + return count; +} + +static DEVICE_ATTR(runtime_suspend_scanrate_ms, S_IRUGO|S_IWUSR, + cyapa_show_rt_suspend_scanrate, + cyapa_update_rt_suspend_scanrate); + +static struct attribute *cyapa_power_runtime_entries[] = { + &dev_attr_runtime_suspend_scanrate_ms.attr, + NULL, +}; + +static const struct attribute_group cyapa_power_runtime_group = { + .name = power_group_name, + .attrs = cyapa_power_runtime_entries, +}; + +static void cyapa_remove_power_runtime_group(void *data) +{ + struct cyapa *cyapa = data; + + sysfs_unmerge_group(&cyapa->client->dev.kobj, + &cyapa_power_runtime_group); +} + +static int cyapa_start_runtime(struct cyapa *cyapa) +{ + int ret; + struct device *dev = &cyapa->client->dev; + + cyapa->runtime_suspend_power_mode = PWR_MODE_IDLE; + cyapa->runtime_suspend_sleep_time = + cyapa_pwr_cmd_to_sleep_time(cyapa->runtime_suspend_power_mode); + + ret = sysfs_merge_group(&dev->kobj, &cyapa_power_runtime_group); + if (ret) { + dev_err(dev, + "failed to create power runtime group, %d\n", ret); + return ret; + } + + ret = devm_add_action(dev, cyapa_remove_power_runtime_group, cyapa); + if (ret) { + cyapa_remove_power_runtime_group(cyapa); + dev_err(dev, + "failed to add power runtime cleanup action, (%d)\n", + ret); + return ret; + } + + pm_runtime_set_active(dev); + pm_runtime_use_autosuspend(dev); + pm_runtime_set_autosuspend_delay(dev, AUTOSUSPEND_DELAY); + pm_runtime_enable(dev); + + return 0; +} +#endif /* CONFIG_PM_RUNTIME */ + /* * Returns: * 0 Driver and device initialization successfully done. @@ -700,6 +814,14 @@ static int cyapa_probe(struct i2c_client *client, } #endif /* CONFIG_PM_SLEEP */ +#ifdef CONFIG_PM_RUNTIME + ret = cyapa_start_runtime(cyapa); + if (ret) { + dev_err(dev, "failed to start pm_runtime, (%d)\n, ", ret); + return ret; + } +#endif /* CONFIG_PM_RUNTIME */ + return 0; } @@ -712,6 +834,8 @@ static int cyapa_remove(struct i2c_client *client) if (cyapa->ops->set_power_mode) cyapa->ops->set_power_mode(cyapa, PWR_MODE_OFF, 0); + pm_runtime_disable(&client->dev); + return 0; } @@ -728,6 +852,7 @@ static int cyapa_suspend(struct device *dev) return ret; } + pm_runtime_disable(dev); /* * Disable IRQ to avoid the command response interrupt cause system * suspending process interrupted and failed. @@ -750,6 +875,8 @@ static int cyapa_suspend(struct device *dev) ret); } + pm_runtime_set_suspended(dev); + if (device_may_wakeup(dev)) cyapa->irq_wake = (enable_irq_wake(cyapa->client->irq) == 0); @@ -771,19 +898,60 @@ static int cyapa_resume(struct device *dev) cyapa->irq_wake = false; } + /* Runtime set active to reflect active state. */ + pm_runtime_set_active(dev); + /* Reset to active power state after re-detected. */ cyapa_detect(cyapa); enable_irq(cyapa->client->irq); + pm_runtime_enable(dev); + if (!ret) mutex_unlock(&cyapa->state_sync_lock); return 0; } #endif /* CONFIG_PM_SLEEP */ +#ifdef CONFIG_PM_RUNTIME +static int cyapa_runtime_suspend(struct device *dev) +{ + int ret; + struct cyapa *cyapa = dev_get_drvdata(dev); + + if (cyapa->input && cyapa->ops->set_power_mode) { + /* Set trackpad device to idle mode. */ + ret = cyapa->ops->set_power_mode(cyapa, + cyapa->runtime_suspend_power_mode, + cyapa->runtime_suspend_sleep_time); + if (ret) + dev_err(dev, "runtime suspend failed, %d\n", ret); + } + + return 0; +} + +static int cyapa_runtime_resume(struct device *dev) +{ + int ret; + struct cyapa *cyapa = dev_get_drvdata(dev); + + if (cyapa->input && cyapa->ops->set_power_mode) { + /* Resume to full active mode. */ + ret = cyapa->ops->set_power_mode(cyapa, + PWR_MODE_FULL_ACTIVE, 0); + if (ret) + dev_err(dev, "runtime resume failed, %d\n", ret); + } + + return 0; +} +#endif /* CONFIG_PM_RUNTIME */ + static const struct dev_pm_ops cyapa_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(cyapa_suspend, cyapa_resume) + SET_RUNTIME_PM_OPS(cyapa_runtime_suspend, cyapa_runtime_resume, NULL) }; static const struct i2c_device_id cyapa_id_table[] = {