From patchwork Sat Dec 6 15:43:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 5450031 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E15D0BEEA8 for ; Sat, 6 Dec 2014 15:44:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 177FF20138 for ; Sat, 6 Dec 2014 15:44:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0DC220131 for ; Sat, 6 Dec 2014 15:44:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbaLFPoG (ORCPT ); Sat, 6 Dec 2014 10:44:06 -0500 Received: from mail-qc0-f180.google.com ([209.85.216.180]:51861 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbaLFPoG (ORCPT ); Sat, 6 Dec 2014 10:44:06 -0500 Received: by mail-qc0-f180.google.com with SMTP id i8so1864338qcq.11 for ; Sat, 06 Dec 2014 07:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=LRGsb3MjWN5zbohl4vjoI4HYbXYHWUo4vmWLiAaO2WY=; b=JLRmDbN75m++2dduDzpb8bkOpvUZn7Yu3IrTmaPCzBNP67vtppyfA0JzWRurJXDlSo ci8O+pABEUGHdtMLrZWVCZGNEIbOVk5ifRpwQvI1JIeHECwC6gA84XbWZ7mUVIwu7091 dSApFmMg5vD55rp3vilO7gXCVMsj39XcBQr6a2wHATUMBM0Es1L+lMaRF/Q/q+LC6Kbr CRTvXNDFCeZbmzDS5+geLmrzBXu0FuLxwZcDEtVtZMoVRMOtZfsQHjhxbSyR+3cMepm+ y3XkeaWPgk0UMDE1r8oDIMsP5z6tCYcFG9r4DntXfBPABQ/pRSLSJ3/mOkwpN1JHySAk Aypw== X-Received: by 10.140.23.198 with SMTP id 64mr35256242qgp.62.1417880644531; Sat, 06 Dec 2014 07:44:04 -0800 (PST) Received: from localhost.localdomain ([187.66.159.54]) by mx.google.com with ESMTPSA id j14sm32846796qar.17.2014.12.06.07.44.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 06 Dec 2014 07:44:03 -0800 (PST) From: Fabio Estevam To: dmitry.torokhov@gmail.com Cc: alexander.stein@systec-electronic.com, linux-input@vger.kernel.org, Fabio Estevam Subject: [PATCH] Input: gpio_keys - initialize the 'irq' variable Date: Sat, 6 Dec 2014 13:43:52 -0200 Message-Id: <1417880632-13559-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Commit f2d347ff70be453e ("Input: gpio_keys - add device tree support for interrupt only keys") caused the following build warning: drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_probe': drivers/input/keyboard/gpio_keys.c:647:15: warning: 'irq' may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/input/keyboard/gpio_keys.c:622:7: note: 'irq' was declared here Initialize 'irq' with a default value to fix it. Reported-by: Olof's autobuilder Signed-off-by: Fabio Estevam --- drivers/input/keyboard/gpio_keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index aa13055..70e89d1 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -619,7 +619,7 @@ gpio_keys_get_devtree_pdata(struct device *dev) i = 0; for_each_child_of_node(node, pp) { int gpio = -1; - int irq; + int irq = -EINVAL; enum of_gpio_flags flags; if (!of_find_property(pp, "gpios", NULL)) {