From patchwork Tue Dec 30 13:47:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 5552261 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E57B3BF6C3 for ; Tue, 30 Dec 2014 13:47:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 051D020172 for ; Tue, 30 Dec 2014 13:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D76C420121 for ; Tue, 30 Dec 2014 13:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750880AbaL3Nrj (ORCPT ); Tue, 30 Dec 2014 08:47:39 -0500 Received: from mail-vc0-f170.google.com ([209.85.220.170]:60827 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbaL3Nri (ORCPT ); Tue, 30 Dec 2014 08:47:38 -0500 Received: by mail-vc0-f170.google.com with SMTP id hy4so5794973vcb.1 for ; Tue, 30 Dec 2014 05:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=8cjKOZTs1y2LpeNxTl7Hlm6s+C24649bBWDSSLYXHeM=; b=funf94Jfs6hcKJ3XE93ZhQ63Un8OhkiJ1xHT0vUgHtHrFBZMU4Lh9zwtm/ZCgAEEmm ynj2UEofD3HPR+LtnaAK+A+y8n4Vu+pKKXpNh0HehdEq3jZudTkcghV+e139G36m52Uh ZhLpiQ5jrcr9DXDkZVI9cb5NyHb1NIprGCxaK81ZFThJmlGJG/7Aoyo5SD3NUYtHh5pG CJqTNBCZ3Z57X5V637GRyXtONig7rvcX9e/ZV2yo0/PIwmFM1IJ4UfrHbsLUX6xJhLv3 P4xRVy0hTadhxDpDL0nU8Sb+y5eQv6N45Ztq1rXhA3CK+1SU2HAwADpOEUsi/DUSbl6f sf7g== X-Received: by 10.52.38.99 with SMTP id f3mr29050032vdk.72.1419947257651; Tue, 30 Dec 2014 05:47:37 -0800 (PST) Received: from localhost.localdomain ([189.101.176.228]) by mx.google.com with ESMTPSA id oz5sm9066842vdb.2.2014.12.30.05.47.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Dec 2014 05:47:36 -0800 (PST) From: Fabio Estevam To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, Fabio Estevam Subject: [PATCH] Input: imx_keypad - use the preferred form for passing a size of a struct Date: Tue, 30 Dec 2014 11:47:16 -0200 Message-Id: <1419947236-17328-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam According to Documentation/CodingStyle - Chapter 14: "The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not." So do it as recommeded. Signed-off-by: Fabio Estevam --- drivers/input/keyboard/imx_keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c index e53f232..2e855e6 100644 --- a/drivers/input/keyboard/imx_keypad.c +++ b/drivers/input/keyboard/imx_keypad.c @@ -448,8 +448,7 @@ static int imx_keypad_probe(struct platform_device *pdev) return -ENOMEM; } - keypad = devm_kzalloc(&pdev->dev, sizeof(struct imx_keypad), - GFP_KERNEL); + keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL); if (!keypad) { dev_err(&pdev->dev, "not enough memory for driver data\n"); return -ENOMEM;