| Message ID | 1427388117-20101-1-git-send-email-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Thu, 26 Mar 2015, Benjamin Tissoires wrote: > The Logitech T650 used to report 3 fingers swipes to the up as a press on > the Super key. When we switched the touchpad to the raw mode, we also > disable such firmware gesture and some users may rely on it. > > Unfortunately, 3 finger swipes are still not supported in most of the > Linux environments, which means that we disabled a feature of the touchpad. > > Allow users to revert the raw reporting mode and keep going with the > firmware gestures by providing a new module parameter. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Applied to for-4.1/logitech.
Hello again! I recently rebooted my laptop just to find out that my touchpad stopped working: no more gestures, no more button clicks supported, tap-to-click is very laggy. Just checked the module history and found commit https://github.com/torvalds/linux/commit/cae253d6033da885e71c29c1591b22838a52de76 with description about "desktop environments can and should support touchpad gestures through libinput". Unfortunately my environment (Fedora 39 KDE) doesn't support it out-of-the-box, and I don't know how to return all the handful features that my touchpad provided. Right now it's slightly better than useless. Is there a way to return this option back? Or provide any guides on how to properly setup all the features? P.S. Sorry for the duplicate - the mail-lists rejected my previous message because of an accidental HTML subpart. On Thu, 2 Apr 2015 at 15:32, Jiri Kosina <jkosina@suse.cz> wrote: > > On Thu, 26 Mar 2015, Benjamin Tissoires wrote: > > > The Logitech T650 used to report 3 fingers swipes to the up as a press on > > the Super key. When we switched the touchpad to the raw mode, we also > > disable such firmware gesture and some users may rely on it. > > > > Unfortunately, 3 finger swipes are still not supported in most of the > > Linux environments, which means that we disabled a feature of the touchpad. > > > > Allow users to revert the raw reporting mode and keep going with the > > firmware gestures by providing a new module parameter. > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Applied to for-4.1/logitech. > > -- > Jiri Kosina > SUSE Labs
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index e77658c..8e9cb25 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -28,6 +28,11 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@gmail.com>"); MODULE_AUTHOR("Nestor Lopez Casado <nlopezcasad@logitech.com>"); +static bool disable_raw_mode; +module_param(disable_raw_mode, bool, 0644); +MODULE_PARM_DESC(disable_raw_mode, + "Disable Raw mode reporting for touchpads and keep firmware gestures."); + #define REPORT_ID_HIDPP_SHORT 0x10 #define REPORT_ID_HIDPP_LONG 0x11 @@ -1188,6 +1193,11 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) hidpp->quirks = id->driver_data; + if (disable_raw_mode) { + hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP; + hidpp->quirks &= ~HIDPP_QUIRK_DELAYED_INIT; + } + if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) { ret = wtp_allocate(hdev, id); if (ret)
The Logitech T650 used to report 3 fingers swipes to the up as a press on the Super key. When we switched the touchpad to the raw mode, we also disable such firmware gesture and some users may rely on it. Unfortunately, 3 finger swipes are still not supported in most of the Linux environments, which means that we disabled a feature of the touchpad. Allow users to revert the raw reporting mode and keep going with the firmware gestures by providing a new module parameter. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/hid/hid-logitech-hidpp.c | 10 ++++++++++ 1 file changed, 10 insertions(+)