From patchwork Fri May 15 21:43:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 6416851 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 28BD19F1CC for ; Fri, 15 May 2015 21:43:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 255782057F for ; Fri, 15 May 2015 21:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A25E20576 for ; Fri, 15 May 2015 21:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231AbbEOVnX (ORCPT ); Fri, 15 May 2015 17:43:23 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:36692 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754597AbbEOVnW (ORCPT ); Fri, 15 May 2015 17:43:22 -0400 Received: by ykep21 with SMTP id p21so38040461yke.3 for ; Fri, 15 May 2015 14:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=T9tmEkXn+MRXnnNeVaex0wWXS/uK5KSUfGA4152RDDo=; b=R7fB8MJFOgebGzBLg/8qaObWKRMspOxkZkLoUQhc+QluqBTarSmxUBgCnf/R1xpSR8 mIWAK8arZcyRsVZxzQXK29M9TdwsVhZ+Q2EewblEePv/iT4vVEGu0rcQTgmdcG+5x33J +b6LsACCwPuIiYwHhi60DbSq4h/4CkLTDLs1eV1az/ldcUlo7Dp3EmB39hADg8lJlZfl ULpzb34I61NIDepLjRgNm6iLwEsKezfF2ZbVFyWBoBG6Yb4QnpcFwkAb6hPY+wS39SO0 6uYouBwkoZ/Z2n//blP0GroIcqEPbcr7AiZ1TOt4CT/Qt0FH7hGcm6lEMVyGTNqe2wQ+ /jQw== X-Received: by 10.236.1.231 with SMTP id 67mr11716885yhd.90.1431726201959; Fri, 15 May 2015 14:43:21 -0700 (PDT) Received: from localhost.localdomain ([177.194.98.179]) by mx.google.com with ESMTPSA id f22sm2085486yhc.0.2015.05.15.14.43.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 14:43:20 -0700 (PDT) From: Fabio Estevam To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, Julia.Lawall@lip6.fr, Fabio Estevam Subject: [PATCH 1/4] Input: twl4030-pwrbutton - pass the IRQF_ONESHOT flag Date: Fri, 15 May 2015 18:43:08 -0300 Message-Id: <1431726191-11466-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. The semantic patch that makes this change is available in scripts/coccinelle/misc/irqf_oneshot.cocci. Signed-off-by: Fabio Estevam --- drivers/input/misc/twl4030-pwrbutton.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index e98cc81..603fc2f 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c @@ -71,7 +71,8 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) pwr->dev.parent = &pdev->dev; err = devm_request_threaded_irq(&pwr->dev, irq, NULL, powerbutton_irq, - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, + IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | + IRQF_ONESHOT, "twl4030_pwrbutton", pwr); if (err < 0) { dev_err(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err);