From patchwork Fri May 15 21:43:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 6416861 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F09759F1CC for ; Fri, 15 May 2015 21:43:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 29E5420584 for ; Fri, 15 May 2015 21:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32FC220576 for ; Fri, 15 May 2015 21:43:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732AbbEOVnZ (ORCPT ); Fri, 15 May 2015 17:43:25 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:33832 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754576AbbEOVnZ (ORCPT ); Fri, 15 May 2015 17:43:25 -0400 Received: by ykft189 with SMTP id t189so38194061ykf.1 for ; Fri, 15 May 2015 14:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LyheZCjscBCkvjN81n+RYumz/8SxsP/vZeo8sAMB4is=; b=viV73RzXMvyGgG8jQtMMlOckd7x49VavpgOYDGZpRjPZEDzpWyHLuHLzCKHBQVov6w KXj4FKMpasWt2/mxL7Q6VhrwQ9WhpMFlVNaXROtCgXgNiA345xriYnljJntZ2fC05jgz YbesY8HtRwRm9Wp+nrsNxvpcd+cBK6ElXo5WqcpqrfwFAr3dbvRNIdzsQD7fQOvuUZff /P6Suq92CJC69qaFNR8+Pr4t5stay6B0sNUc88JVAqWfw4SNAKnuwyg0w+G64mlL0lOa Knj7IrveCpjiXtNS0LfoyeCaTgrkMyXJLSoVozjGhnZmUPiWMQIzi7A3e6qIq1AUagoJ QWMw== X-Received: by 10.236.209.195 with SMTP id s43mr11348390yho.131.1431726204549; Fri, 15 May 2015 14:43:24 -0700 (PDT) Received: from localhost.localdomain ([177.194.98.179]) by mx.google.com with ESMTPSA id f22sm2085486yhc.0.2015.05.15.14.43.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 14:43:23 -0700 (PDT) From: Fabio Estevam To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, Julia.Lawall@lip6.fr, Fabio Estevam Subject: [PATCH 2/4] Input: retu-pwrbutton - pass the IRQF_ONESHOT flag Date: Fri, 15 May 2015 18:43:09 -0300 Message-Id: <1431726191-11466-2-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1431726191-11466-1-git-send-email-festevam@gmail.com> References: <1431726191-11466-1-git-send-email-festevam@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. The semantic patch that makes this change is available in scripts/coccinelle/misc/irqf_oneshot.cocci. Signed-off-by: Fabio Estevam --- drivers/input/misc/retu-pwrbutton.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/misc/retu-pwrbutton.c b/drivers/input/misc/retu-pwrbutton.c index 0c8ac60..30b459b 100644 --- a/drivers/input/misc/retu-pwrbutton.c +++ b/drivers/input/misc/retu-pwrbutton.c @@ -63,7 +63,8 @@ static int retu_pwrbutton_probe(struct platform_device *pdev) input_set_drvdata(idev, rdev); error = devm_request_threaded_irq(&pdev->dev, irq, - NULL, retu_pwrbutton_irq, 0, + NULL, retu_pwrbutton_irq, + IRQF_ONESHOT, "retu-pwrbutton", idev); if (error) return error;