From patchwork Fri May 15 21:43:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 6416881 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 332339F1CC for ; Fri, 15 May 2015 21:43:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 556C82057E for ; Fri, 15 May 2015 21:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F02220576 for ; Fri, 15 May 2015 21:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576AbbEOVna (ORCPT ); Fri, 15 May 2015 17:43:30 -0400 Received: from mail-yh0-f41.google.com ([209.85.213.41]:34214 "EHLO mail-yh0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754711AbbEOVna (ORCPT ); Fri, 15 May 2015 17:43:30 -0400 Received: by yhom41 with SMTP id m41so35449795yho.1 for ; Fri, 15 May 2015 14:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l9ZEYvRfY/RlTMYpzR7edkoVvbrqDLKgkD3P3ADumOg=; b=L7fRfz1f0O62S3sNIjnktvMt4zKuJMRidq/fJZ/NXk0/AvSVG6IQYmqxrxHtkzwpMN RQKeHNFw82evSvPFPPbByfMmcOtMbakRfXE1epP4aJtUO+Q1RE1UVz561GocLGNupFem FxzGMmWNKa+YjCVMjwOFEmNwp31JEMAJu5rYDPf5qqTIp1PWrhbcZ/R0Lq8KanZ7yGB8 1Yl0cJl2GORQATqWOZuJlPmlz9rJi9VZnGQAdRDbThmMW+arKeBJnVEiXfQOQAOjkuvL TErGfaKJM9R38S6JXrskDwdVpnU/H0MUzzSICXjWsBXNfxRhcZJ8oPXPKw1SPQjZQoWv GzkQ== X-Received: by 10.236.1.135 with SMTP id 7mr11408086yhd.186.1431726209729; Fri, 15 May 2015 14:43:29 -0700 (PDT) Received: from localhost.localdomain ([177.194.98.179]) by mx.google.com with ESMTPSA id f22sm2085486yhc.0.2015.05.15.14.43.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 14:43:28 -0700 (PDT) From: Fabio Estevam To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, Julia.Lawall@lip6.fr, Fabio Estevam Subject: [PATCH 4/4] Input: wm831x-on - pass the IRQF_ONESHOT flag Date: Fri, 15 May 2015 18:43:11 -0300 Message-Id: <1431726191-11466-4-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1431726191-11466-1-git-send-email-festevam@gmail.com> References: <1431726191-11466-1-git-send-email-festevam@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. The semantic patch that makes this change is available in scripts/coccinelle/misc/irqf_oneshot.cocci. Signed-off-by: Fabio Estevam --- drivers/input/misc/wm831x-on.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c index 59d4f7b..1b44de2 100644 --- a/drivers/input/misc/wm831x-on.c +++ b/drivers/input/misc/wm831x-on.c @@ -99,7 +99,8 @@ static int wm831x_on_probe(struct platform_device *pdev) wm831x_on->dev->dev.parent = &pdev->dev; ret = request_threaded_irq(irq, NULL, wm831x_on_irq, - IRQF_TRIGGER_RISING, "wm831x_on", + IRQF_TRIGGER_RISING | IRQF_ONESHOT, + "wm831x_on", wm831x_on); if (ret < 0) { dev_err(&pdev->dev, "Unable to request IRQ: %d\n", ret);