| Message ID | 1434484984-15418-1-git-send-email-frodo_lai@bcmcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 16, 2015 at 01:03:04PM -0700, Frodo Lai wrote: > The i2c_master_recv() uses readsize to receive data from i2c but > compares to size of rdbuf which is always 27. This would casue > problem when the max_fingers is not 5. Change the comparison value > to readsize instead. > > Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com> Applied, thank you. > --- > drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c > index 2c21071..8f3e243 100644 > --- a/drivers/input/touchscreen/pixcir_i2c_ts.c > +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c > @@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata, > } > > ret = i2c_master_recv(tsdata->client, rdbuf, readsize); > - if (ret != sizeof(rdbuf)) { > + if (ret != readsize) { > dev_err(&tsdata->client->dev, > "%s: i2c_master_recv failed(), ret=%d\n", > __func__, ret); > -- > 1.7.9.5 >
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c index 2c21071..8f3e243 100644 --- a/drivers/input/touchscreen/pixcir_i2c_ts.c +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c @@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata, } ret = i2c_master_recv(tsdata->client, rdbuf, readsize); - if (ret != sizeof(rdbuf)) { + if (ret != readsize) { dev_err(&tsdata->client->dev, "%s: i2c_master_recv failed(), ret=%d\n", __func__, ret);
The i2c_master_recv() uses readsize to receive data from i2c but compares to size of rdbuf which is always 27. This would casue problem when the max_fingers is not 5. Change the comparison value to readsize instead. Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com> --- drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)