diff mbox

[07/11] Input: synaptics-rmi4 - f11: fix bitmap irq check

Message ID 1435087050-11444-8-git-send-email-benjamin.tissoires@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Benjamin Tissoires June 23, 2015, 7:17 p.m. UTC 
num_irq_regs is the count of registers of 1 bytes that we use to check
the irqs. bitmap_and() expects the number of bits.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/input/rmi4/rmi_f11.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Duggan July 2, 2015, 5:50 p.m. UTC | #1 
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
> num_irq_regs is the count of registers of 1 bytes that we use to check
> the irqs. bitmap_and() expects the number of bits.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---

Reviewed-by: Andrew Duggan <aduggan@synaptics.com>

>   drivers/input/rmi4/rmi_f11.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index 99d6181..c3b757b 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -726,12 +726,12 @@ static void rmi_f11_finger_handler(struct f11_data *f11,
>   		}
>   
>   		abs_bits = bitmap_and(f11->result_bits, irq_bits, f11->abs_mask,
> -				      num_irq_regs);
> +				      num_irq_regs * 8);
>   		if (abs_bits)
>   			rmi_f11_abs_pos_report(f11, sensor, finger_state, i);
>   
>   		rel_bits = bitmap_and(f11->result_bits, irq_bits, f11->rel_mask,
> -				      num_irq_regs);
> +				      num_irq_regs * 8);
>   		if (rel_bits)
>   			rmi_f11_rel_pos_report(sensor, i);
>   	}

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index 99d6181..c3b757b 100644
--- a/drivers/input/rmi4/rmi_f11.c
+++ b/drivers/input/rmi4/rmi_f11.c
@@ -726,12 +726,12 @@  static void rmi_f11_finger_handler(struct f11_data *f11,
 		}
 
 		abs_bits = bitmap_and(f11->result_bits, irq_bits, f11->abs_mask,
-				      num_irq_regs);
+				      num_irq_regs * 8);
 		if (abs_bits)
 			rmi_f11_abs_pos_report(f11, sensor, finger_state, i);
 
 		rel_bits = bitmap_and(f11->result_bits, irq_bits, f11->rel_mask,
-				      num_irq_regs);
+				      num_irq_regs * 8);
 		if (rel_bits)
 			rmi_f11_rel_pos_report(sensor, i);
 	}