From patchwork Tue Jul 7 00:27:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 6729141 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0D0189F40A for ; Tue, 7 Jul 2015 00:27:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 33E8D20384 for ; Tue, 7 Jul 2015 00:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57CAC201BC for ; Tue, 7 Jul 2015 00:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756274AbbGGA1v (ORCPT ); Mon, 6 Jul 2015 20:27:51 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:35825 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756275AbbGGA1t (ORCPT ); Mon, 6 Jul 2015 20:27:49 -0400 Received: by igcqs7 with SMTP id qs7so21977737igc.0; Mon, 06 Jul 2015 17:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=VQ7kWQM0pRHHKK6k1f8+5Hxobt4czBUiLuRJtAV6nDU=; b=dkDdrpPzPQo1zimWMFViARzwZtTLkyPgj8m2/AYu1tvJCVxCjC8xF3B0C444RQMekr WAls8oma5FAWJl885MlvCcToo6MLTTVYi0yKchIQ1+uIdJfEZ2bdybDPJGD3bvB0D3ih wnAGI9vgrJLf7aMCjljcEhoC/z7nBthdD+MnqDyIGBXyNqYukT03+VGxaLvivhnNxO1q Rx+KttQylAMrMZA57pORp/ZLxmBLR3/UOf+4E7gCUU8/po8wpkxDO8iLe+aZSeSZIZ8c E5xjTJpXN4Ee0KaVaw9W9twvrVliefX1d16lh/nARmuur1vPOVnbxUkBaFOUTBO5ieFh B4jg== X-Received: by 10.50.13.34 with SMTP id e2mr45155334igc.23.1436228868348; Mon, 06 Jul 2015 17:27:48 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([172.22.64.149]) by mx.google.com with ESMTPSA id rj5sm10785093igc.2.2015.07.06.17.27.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jul 2015 17:27:47 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org, Maxime Ripard , Sebastian Reichel Cc: Pavel Machek , Roger Quadros , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] Input: of_touchscreen - always issue warning if axis is not set up Date: Mon, 6 Jul 2015 17:27:27 -0700 Message-Id: <1436228849-29530-1-git-send-email-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.4.3.573.g4eafbef Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Do issue warning about axis that is present in device tree but not specified by the driver even in case of multi-touch axis as callers now tell us if they expect multi-touch data or not. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/of_touchscreen.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/of_touchscreen.c b/drivers/input/touchscreen/of_touchscreen.c index 806cd0a..759cf4b 100644 --- a/drivers/input/touchscreen/of_touchscreen.c +++ b/drivers/input/touchscreen/of_touchscreen.c @@ -39,13 +39,9 @@ static void touchscreen_set_params(struct input_dev *dev, struct input_absinfo *absinfo; if (!test_bit(axis, dev->absbit)) { - /* - * Emit a warning only if the axis is not a multitouch - * axis, which might not be set by the driver. - */ - if (!input_is_mt_axis(axis)) - dev_warn(&dev->dev, - "DT specifies parameters but the axis is not set up\n"); + dev_warn(&dev->dev, + "DT specifies parameters but the axis %lu is not set up\n", + axis); return; }