From patchwork Mon Jul 13 22:23:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ellen Wang X-Patchwork-Id: 6782511 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 681F19F6CE for ; Mon, 13 Jul 2015 22:24:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8C6D02056D for ; Mon, 13 Jul 2015 22:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4555920584 for ; Mon, 13 Jul 2015 22:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbbGMWYC (ORCPT ); Mon, 13 Jul 2015 18:24:02 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33118 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbbGMWX7 (ORCPT ); Mon, 13 Jul 2015 18:23:59 -0400 Received: by padck2 with SMTP id ck2so49420386pad.0 for ; Mon, 13 Jul 2015 15:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id; bh=KISpF4V6s2LG79b1XS1kuaEUvZ6RICfh9FKNm1WNhjM=; b=JDTmcxEBolUfNQX/ffGFqFFU1yvmjK/YEvBC58FClQkl34OOq3QwT4P1zdFM20aIuQ RrsMjm7hiSjZ/0wqfm5K753CNj503rA90jYxDIQu3dTq29lF63lqGkTDAlZaJKOWQqnB i1JukBoFWKEH5rji9HxDt2sQZnrcwyELJ35Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KISpF4V6s2LG79b1XS1kuaEUvZ6RICfh9FKNm1WNhjM=; b=gGdv8CZ1s/LEjg5CjejKCUc8lVUMFB/NO0mMscln+cTO+h007HhNQqCrBfpzAQsA7u 4U0upr5Htqr8im+ZAZmnBsiVPogslMKUADOjfOpZoTeeH/+0keT7EfDkm0MtakP/3v3J j8adGO9XYtZnNeIHH9jJ7VS6ESAvrduFrLCPQLpcbAnj8aQYRVMOILWwpzRJHFKLdIib TLWk4g3dq/fr+ndb7aZfRqabdO061BMKK0qdJ4/smn4Lvy94cauedQY5ZeiE4GKG0ur8 0z+gcB59V3edX3dreoIu+r7T9Z2lL8xhRUmZDXyORbxG6t24ctvstxSE0Ev3jBJMplG2 tTbw== X-Gm-Message-State: ALoCoQlKjzEmtyp6MRJ054uCC8i4JiCgRkuZJO89aYx6H1SflMBjsXUNgNAqy9aFwbm2mrfHzsM6 X-Received: by 10.70.48.34 with SMTP id i2mr73853358pdn.125.1436826239274; Mon, 13 Jul 2015 15:23:59 -0700 (PDT) Received: from monster-01.cumulusnetworks.com ([216.129.126.126]) by smtp.gmail.com with ESMTPSA id qa10sm19565095pbc.44.2015.07.13.15.23.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 15:23:58 -0700 (PDT) From: Ellen Wang To: borneo.antonio@gmail.com, dbarksdale@uplogix.com, jkosina@suse.cz, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org Cc: ellen@cumulusnetworks.com Subject: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write Date: Mon, 13 Jul 2015 15:23:54 -0700 Message-Id: <1436826234-2447-1-git-send-email-ellen@cumulusnetworks.com> X-Mailer: git-send-email 1.9.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When doing an I2C_SMBUS_BYTE write (one byte write, no address), the data to be written is in "command" not "data->byte". Signed-off-by: Ellen Wang Reviewed-by: Antonio Borneo Acked-by: Wolfram Sang --- Forgot signed-off-by tag last time, sorry. --- drivers/hid/hid-cp2112.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index a3703b8..7afc3fc 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -606,7 +606,7 @@ static int cp2112_xfer(struct i2c_adapter *adap, u16 addr, if (I2C_SMBUS_READ == read_write) count = cp2112_read_req(buf, addr, read_length); else - count = cp2112_write_req(buf, addr, data->byte, NULL, + count = cp2112_write_req(buf, addr, command, NULL, 0); break; case I2C_SMBUS_BYTE_DATA: