From patchwork Fri Sep 18 11:24:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7215371 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 66132BEEC1 for ; Fri, 18 Sep 2015 11:24:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81A092095E for ; Fri, 18 Sep 2015 11:24:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B2072095C for ; Fri, 18 Sep 2015 11:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751702AbbIRLYu (ORCPT ); Fri, 18 Sep 2015 07:24:50 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35143 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbIRLYt (ORCPT ); Fri, 18 Sep 2015 07:24:49 -0400 Received: by pacfv12 with SMTP id fv12so49937779pac.2; Fri, 18 Sep 2015 04:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=72pg+q4R+tCGNJCl3/zD0vMtnQBimafJRn7LQsnCXBo=; b=TQ7kBytdDWTILnlpKcu+VqW/Kte7bkm+i34pfYuFHWrh7XajQWUgYbz7uzf49+FyyH mus8KBEzsPaBEcLu0ERQjWLsmeqfzJMepUl3RIEcQEZ5/V0e+3po5cn6sIUmRBaJe7xm KH45OQppig0RGfzwJeLIQ8ydNfnZE/ztmkRxJCEijDNEBISnTiJT37d7wJRPSat8gMll 9HR8VRybMPtB2vIBklRBZbXwhvpuFQN/oCmsLzwTxD02UbbTYx2N6EPSeGPNh5+jmAaI 7P6SCyHUiTpuY2lzuKeVVGLtdYO5HUCcuonZwZZdD9X90QVQzQ+zy7K8a0Jwt/o/gVBh DvpQ== X-Received: by 10.68.57.143 with SMTP id i15mr6802827pbq.104.1442575489257; Fri, 18 Sep 2015 04:24:49 -0700 (PDT) Received: from localhost.localdomain ([49.206.255.164]) by smtp.gmail.com with ESMTPSA id d13sm8558772pbu.17.2015.09.18.04.24.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Sep 2015 04:24:48 -0700 (PDT) From: Sudip Mukherjee To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] Input: omap-keypad: fix memory leak Date: Fri, 18 Sep 2015 16:54:40 +0530 Message-Id: <1442575480-336-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If omap4_keypad_parse_dt() fails we returned the error code but we missed releasing keypad_data. Signed-off-by: Sudip Mukherjee --- drivers/input/keyboard/omap4-keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index b052afe..6639b2b 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -266,7 +266,7 @@ static int omap4_keypad_probe(struct platform_device *pdev) error = omap4_keypad_parse_dt(&pdev->dev, keypad_data); if (error) - return error; + goto err_free_keypad; res = request_mem_region(res->start, resource_size(res), pdev->name); if (!res) {