From patchwork Tue Nov 17 13:40:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7637351 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A6BA4BF90C for ; Tue, 17 Nov 2015 13:42:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E26F62052D for ; Tue, 17 Nov 2015 13:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A61B20528 for ; Tue, 17 Nov 2015 13:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbbKQNkf (ORCPT ); Tue, 17 Nov 2015 08:40:35 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36588 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393AbbKQNkc (ORCPT ); Tue, 17 Nov 2015 08:40:32 -0500 Received: by pacdm15 with SMTP id dm15so9539221pac.3; Tue, 17 Nov 2015 05:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9Y7WulF6C4yX4UaAwe6gxS2aj31Dha5AbXpWAtwZksk=; b=erYoE9x1XArCUTolZkd8EDUt3TyiTHWgLsOmSkrWbTNKDTLWT8jpHy5H8ItG5bg7Bd ZgspshvyXbmXPJbTxstmIVTfexK8ycUJSZXUWjfUGf4Ow+6ZaxVY0tQi5ju4jguJda9z ddf/tvPTJ5sJIMCjyX3f2disTX3CkgNnkREnzliMh1NbrO+e6OpA8l2YMsft1wKPb7L/ mqdIpmTKxJ6ehohK8evmMIoBPmDQn7Bzf9sya2nsogPjs0IjP0Jh2T3nvISmNo02woKK ulNrXIynnU1hGzxuUlFYxhdedLKVJzX5YSkFT0MP7QkB6EVX7H/jzWcLn4jabbqg9aj3 MjmQ== X-Received: by 10.66.227.197 with SMTP id sc5mr63910558pac.157.1447767632109; Tue, 17 Nov 2015 05:40:32 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([122.169.153.10]) by smtp.gmail.com with ESMTPSA id pa4sm43099411pbc.0.2015.11.17.05.40.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Nov 2015 05:40:31 -0800 (PST) From: Sudip Mukherjee To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 2/5] Input: gamecon - clear unused function pointers Date: Tue, 17 Nov 2015 19:10:16 +0530 Message-Id: <1447767619-28329-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447767619-28329-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1447767619-28329-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gc_parport_cb is a local uninitialized structure and the member function pointers will be pointing to arbitrary locations unless they are cleared. Fixes: a517e87c3dfc ("Input: gamecon - use parallel port device model") Signed-off-by: Sudip Mukherjee --- drivers/input/joystick/gamecon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c index 5a672dc..eae14d5 100644 --- a/drivers/input/joystick/gamecon.c +++ b/drivers/input/joystick/gamecon.c @@ -951,6 +951,7 @@ static void gc_attach(struct parport *pp) pads = gc_cfg[port_idx].args + 1; n_pads = gc_cfg[port_idx].nargs - 1; + memset(&gc_parport_cb, 0, sizeof(gc_parport_cb)); gc_parport_cb.flags = PARPORT_FLAG_EXCL; pd = parport_register_dev_model(pp, "gamecon", &gc_parport_cb,