From patchwork Tue Nov 17 13:40:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7637321 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2819BBF90C for ; Tue, 17 Nov 2015 13:41:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 555A920528 for ; Tue, 17 Nov 2015 13:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59564204B5 for ; Tue, 17 Nov 2015 13:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbbKQNkk (ORCPT ); Tue, 17 Nov 2015 08:40:40 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33342 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393AbbKQNkh (ORCPT ); Tue, 17 Nov 2015 08:40:37 -0500 Received: by pabfh17 with SMTP id fh17so10035716pab.0; Tue, 17 Nov 2015 05:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0IUbCZ7yHyOqlNFg+8zdyE0cmosnDwCr9Gcogfn/Snc=; b=RBQwviiU6zDLjG2aviq/Ai0gsnio1Ad3ydILz5YlwZvnjRlJrMUZ1M8QURJ8wIAf/n utboegSqLEWhWgYithtXxScpqprbXs2pB9z5uAxZsMQcBjtLB9BMg4DzoVAHoVkdbWax RAFbctQjYg2rp9wdlD4Ukp57W47p1z3BlukAw8cmcy7rMXBuyLhacrEj3mNzj4flqZtO 1qHFJQelOsBV/Eo/pKnkCrzrYcbxai0qOiuUUYyEEkvDnpFuCJgMBQXNKd5s2VW/qk1s 7Mj67JKPYiySr3fyMPQfQh3AQGbYb+88YE2b9JTbcdZmK7ZEuipYsT+szIlT/BWn1Ft2 Xfqw== X-Received: by 10.68.197.67 with SMTP id is3mr63382707pbc.89.1447767637020; Tue, 17 Nov 2015 05:40:37 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([122.169.153.10]) by smtp.gmail.com with ESMTPSA id pa4sm43099411pbc.0.2015.11.17.05.40.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Nov 2015 05:40:36 -0800 (PST) From: Sudip Mukherjee To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 4/5] Input: walkera0701 - clear unused function pointers Date: Tue, 17 Nov 2015 19:10:18 +0530 Message-Id: <1447767619-28329-4-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447767619-28329-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1447767619-28329-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP walkera0701_parport_cb is a local uninitialized structure and the member function pointers will be pointing to arbitrary locations unless they are cleared. Fixes: 221bcb24c653 ("Input: walkera0701 - use parallel port device model") Signed-off-by: Sudip Mukherjee --- drivers/input/joystick/walkera0701.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/joystick/walkera0701.c b/drivers/input/joystick/walkera0701.c index 9c07fe9..70a893a 100644 --- a/drivers/input/joystick/walkera0701.c +++ b/drivers/input/joystick/walkera0701.c @@ -218,6 +218,7 @@ static void walkera0701_attach(struct parport *pp) w->parport = pp; + memset(&walkera0701_parport_cb, 0, sizeof(walkera0701_parport_cb)); walkera0701_parport_cb.flags = PARPORT_FLAG_EXCL; walkera0701_parport_cb.irq_func = walkera0701_irq_handler; walkera0701_parport_cb.private = w;