From patchwork Fri Jan 29 13:38:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 8163241 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A233FBEEE5 for ; Fri, 29 Jan 2016 13:38:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9F0EE20386 for ; Fri, 29 Jan 2016 13:38:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B04FB20383 for ; Fri, 29 Jan 2016 13:38:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbcA2NiY (ORCPT ); Fri, 29 Jan 2016 08:38:24 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34656 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbcA2NiX (ORCPT ); Fri, 29 Jan 2016 08:38:23 -0500 Received: by mail-pf0-f196.google.com with SMTP id 65so3811884pfd.1; Fri, 29 Jan 2016 05:38:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hE9ECmH9KrO7JpXpOIeamksJpytFCeAzcqHWwaIDEZE=; b=Mr5MCQBIpSpClFv116mLX2U/q8fmdUA00SrH4UE5HuM81+XxVu/e78r+KbgZkG8Paq R4KG1G70TGHt4MgF109fUusmIFCCssg90M6r6X+ln5TftWtdeJVirmkwg8ftvwtW60zy lMS6U3dk7mscQwUaTVkDs6k/QyFbiTDRkylfddXy6oa362dufo0aOwjt+Kxvtnl5A2hd nNU84yA2QjYGiqtqKIoo8L7vFiLHY+m/0bvwUka/p0wEpx3a0V9sfj/3ZnoQg8P+e3/W dsT7furtOgM2Lq72mScJlxCVUzLQrotCoJR2g4H+W2wOK2f155m24hv5AUUvjH397T2g OCgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hE9ECmH9KrO7JpXpOIeamksJpytFCeAzcqHWwaIDEZE=; b=Z4MkQsDZn3CmsjRuyx7p14fs4eh1o0gCqZQd6YfnzJSZ1bJTEaknE8pALfNh9yolnt xzJt+XWyrL5cT4h2HubXUPcPtXCsgel6sp4mO1dqKq1GHhvANyJEiBydq51/l4Nr8/pc MPOeR2sImVU+5bkCHUSy0HUkZgVn2AHrHOpSoYPsnB/EM4X10muKx6vrBmGoPzpOG4fJ kyA2JDQ2xNg72+t0wqZrctfRRD9Phinx+ooSXOIhSFlPaiGpSVXxjddcgKxN337E92kM 8nCJqaGZehg+I0xi8Cm1NqJR/Gyjlzf+p6uT3wvu6UYBs19i0yWUgxkob+gfepS398bt BfSA== X-Gm-Message-State: AG10YOQncIUllRYAG4doTo8RsK0d0xw/2CHSIErfHV4PHdJQJH4IVazERroFkjX3U9orog== X-Received: by 10.98.14.209 with SMTP id 78mr13335447pfo.157.1454074702402; Fri, 29 Jan 2016 05:38:22 -0800 (PST) Received: from lianli.shorne-pla.net (z236.124-44-185.ppp.wakwak.ne.jp. [124.44.185.236]) by smtp.gmail.com with ESMTPSA id 63sm23782728pfo.67.2016.01.29.05.38.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jan 2016 05:38:21 -0800 (PST) Received: from lianli.shorne-pla.net (localhost [127.0.0.1]) by lianli.shorne-pla.net (8.15.2/8.15.2) with ESMTPS id u0TDcJcP017115 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 29 Jan 2016 22:38:19 +0900 Received: (from shorne@localhost) by lianli.shorne-pla.net (8.15.2/8.15.2/Submit) id u0TDcI4j017114; Fri, 29 Jan 2016 22:38:18 +0900 From: Stafford Horne To: jikos@kernel.org Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Stafford Horne Subject: [PATCH v2] HID: quirks: Add no_init_reports for AKAI midi controller Date: Fri, 29 Jan 2016 22:38:07 +0900 Message-Id: <1454074687-17073-1-git-send-email-shorne@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: References: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The midi controller times-out while initializing reports, this causes boot to take an extra 10 seconds. The device descriptor advertises that it has an internal HID device but seems to not actually do anything useful. Signed-off-by: Stafford Horne Reviewed-by: Benjamin Tissoires --- Resending the same patch for the keyboard to simply disable init reports, as discussed with Oliver there might be some hidden functionality which I will look into. At the moment I dont want to worry about time timeouts. Also, I did create and test a patch to use HID_QUIRK_IGNORE which I can send if you feel strongly about it. Changes in v2 - use tabs instead of spaces in hid-ids.h drivers/hid/hid-ids.h | 3 +++ drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index b6ff6e7..74ed730 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -61,6 +61,9 @@ #define USB_VENDOR_ID_AIREN 0x1a2c #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002 +#define USB_VENDOR_ID_AKAI 0x2011 +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715 + #define USB_VENDOR_ID_ALCOR 0x058f #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720 diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 7dd0953..055e740 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -55,6 +55,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET }, + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET },