| Message ID | 1454854687-21114-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Feb 07, 2016 at 03:18:06PM +0100, Geert Uytterhoeven wrote: > drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’: > drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’ > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied, thank you. > --- > Seen with "[PATCH 2/2] Input: Allow compile test of Goodix and Colibri > VF50 if !GPIOLIB" on m68k/allmodconfig > > drivers/input/touchscreen/colibri-vf50-ts.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c > index 5d4903a402cc6a5f..69828d015d45ffa4 100644 > --- a/drivers/input/touchscreen/colibri-vf50-ts.c > +++ b/drivers/input/touchscreen/colibri-vf50-ts.c > @@ -21,6 +21,7 @@ > #include <linux/interrupt.h> > #include <linux/kernel.h> > #include <linux/module.h> > +#include <linux/of.h> > #include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > -- > 1.9.1 >
On Tue, Feb 9, 2016 at 7:33 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Sun, Feb 07, 2016 at 03:18:06PM +0100, Geert Uytterhoeven wrote: >> drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’: >> drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’ >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Applied, thank you. Apparently you only applied patch 2/2, causing the abovementioned breakage in -next? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 10, 2016 at 10:52:39AM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 9, 2016 at 7:33 PM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > On Sun, Feb 07, 2016 at 03:18:06PM +0100, Geert Uytterhoeven wrote: > >> drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’: > >> drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’ > >> > >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > > Applied, thank you. > > Apparently you only applied patch 2/2, causing the abovementioned > breakage in -next? Hmm, I applied both, the Kconfig change went to next and include went into for-linus and they both should have ended up in linux-next... Thanks.
diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c index 5d4903a402cc6a5f..69828d015d45ffa4 100644 --- a/drivers/input/touchscreen/colibri-vf50-ts.c +++ b/drivers/input/touchscreen/colibri-vf50-ts.c @@ -21,6 +21,7 @@ #include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/pinctrl/consumer.h> #include <linux/platform_device.h> #include <linux/slab.h>
drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’: drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’ Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- Seen with "[PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB" on m68k/allmodconfig drivers/input/touchscreen/colibri-vf50-ts.c | 1 + 1 file changed, 1 insertion(+)