| Message ID | 1459282241-25154-1-git-send-email-gabriele.mzt@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Gabriele, Thanks for the fix! On Tue, Mar 29, 2016 at 1:10 PM, Gabriele Mazzotta <gabriele.mzt@gmail.com> wrote: > input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called > at each frame. Do it when releasing the touches, or else we won't get > a proper slot number after mt_reset_resume(). > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/hid/hid-multitouch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 25d3c43..c741f5e 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid) > MT_TOOL_FINGER, > false); > } > + input_mt_sync_frame(input_dev); > input_sync(input_dev); > } > } > -- > 2.8.0.rc3 >
On Mar 29 2016 or thereabouts, Gabriele Mazzotta wrote: > input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called > at each frame. Do it when releasing the touches, or else we won't get > a proper slot number after mt_reset_resume(). > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Thanks for the fix (I should have spot that earlier :( ) Reviewed-by: Benjamin TIssoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > --- > drivers/hid/hid-multitouch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 25d3c43..c741f5e 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid) > MT_TOOL_FINGER, > false); > } > + input_mt_sync_frame(input_dev); > input_sync(input_dev); > } > } > -- > 2.8.0.rc3 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 29 Mar 2016, Gabriele Mazzotta wrote: > input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called > at each frame. Do it when releasing the touches, or else we won't get > a proper slot number after mt_reset_resume(). > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Queued for 4.6. Thanks,
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 25d3c43..c741f5e 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid) MT_TOOL_FINGER, false); } + input_mt_sync_frame(input_dev); input_sync(input_dev); } }
input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called at each frame. Do it when releasing the touches, or else we won't get a proper slot number after mt_reset_resume(). Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> --- drivers/hid/hid-multitouch.c | 1 + 1 file changed, 1 insertion(+)