From patchwork Mon Apr 4 18:26:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gerecke X-Patchwork-Id: 8743591 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 17700C0553 for ; Mon, 4 Apr 2016 18:27:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4DA102025A for ; Mon, 4 Apr 2016 18:27:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F25E2024F for ; Mon, 4 Apr 2016 18:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755443AbcDDS1P (ORCPT ); Mon, 4 Apr 2016 14:27:15 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35160 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755401AbcDDS1P (ORCPT ); Mon, 4 Apr 2016 14:27:15 -0400 Received: by mail-pa0-f65.google.com with SMTP id zy2so4292641pac.2 for ; Mon, 04 Apr 2016 11:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4U357wF0drhBH0eCl2N8VHY89O2fu9WWO4yMqkP3F1Q=; b=MiJ1p1ChVUPxmqsAZ9Qw8a6eVvRbOHYsRrMuE4gIIRJ67E+wPZcT+2oTBhVr61wX4P 7BnVDQMU+dy8ha5QuTzM0eru7aEGTDL6CCCL9JFUhchpSopmdphCXACXyA8uSF1rqx8S cUSX2Jq2gBaUAZ3Mx2Wn0EalOHE4w8ObYdv1v78MgD2QoR9vAdNLucokmSxC5jl0C4Dn m84MQgAR6u717EIvFBcZ9VdbI2w0GiDoEWkY6XtgCdwlTfBEz43EJT86vpq64Sl4JYhb zLOdV6y0l3xF5XVPnPsZs8aRXSmVR9JCjz7pz2XpYbGkpZVhRlVwptAUG1fHH+iIHRy9 bA9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4U357wF0drhBH0eCl2N8VHY89O2fu9WWO4yMqkP3F1Q=; b=ED03hCJcRGAWVpAf/4fSlGPvHEOQwQE9/a7cF8f/dH6MAngbU+K+LY6AZmTdEv4e5t jx1SiRHqjq/qOTgCW33zRAjjSyH25E8mZeyJl1kz39YEkkR9kxsR/n49gnWyy99KYji5 wOptPeHkkRDymgp19aEa8eWQB7lCYjlg7KTc5ZXHAxpLRehWbRGr/h68y1H7qC+oO9vt A0YMlKkrTZl/9obcZAoR0aX2WnubPCfJBYLE0zdBSKKFMHwnSehEKT6L3KlmAhGjMzEh BKFbM2FHIvtPtxOLlpUf34/JOkY1m4ENe0QzWQT1xq29XT/jCbbJSpmd1qWFB5kszi0y +dfA== X-Gm-Message-State: AD7BkJJhUeI2U4Z5Rvs4FiC5R016EUt4yEDYSktxXGJZeRHWsLIbemzG7Lbo+XgvLa7kPg== X-Received: by 10.66.167.145 with SMTP id zo17mr54868696pab.73.1459794434213; Mon, 04 Apr 2016 11:27:14 -0700 (PDT) Received: from wacom-arch2.corp.onewacom.com ([67.51.163.2]) by smtp.gmail.com with ESMTPSA id q4sm41094424pfi.94.2016.04.04.11.27.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Apr 2016 11:27:13 -0700 (PDT) From: Jason Gerecke To: linux-input@vger.kernel.org Cc: Benjamin Tissoires , Ping Cheng , Jiri Kosina , Jason Gerecke , Jason Gerecke Subject: [PATCH v2 1/2] HID: wacom: Initialize hid_data.inputmode to -1 Date: Mon, 4 Apr 2016 11:26:51 -0700 Message-Id: <1459794412-10306-1-git-send-email-killertofu@gmail.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <56FD84F4.6060707@gmail.com> References: <56FD84F4.6060707@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 5ae6e89 introduced hid_data.inputmode with a comment that it would have the value -1 if undefined, but then forgot to actually perform the initialization. Although this doesn't appear to have caused any problems in practice, it should still be remedied. Signed-off-by: Jason Gerecke --- Changes from v1: * Introduce this patch drivers/hid/wacom_sys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 68a5609..b338bbf 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -1817,6 +1817,8 @@ static int wacom_probe(struct hid_device *hdev, goto fail_type; } + wacom_wac->hid_data.inputmode = -1; + wacom->usbdev = dev; wacom->intf = intf; mutex_init(&wacom->lock);