From patchwork Thu Apr 14 03:12:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zengzhaoxiu@163.com X-Patchwork-Id: 8831161 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7869C9F54F for ; Thu, 14 Apr 2016 03:29:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 923A0202DD for ; Thu, 14 Apr 2016 03:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4A52202D1 for ; Thu, 14 Apr 2016 03:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbcDND3S (ORCPT ); Wed, 13 Apr 2016 23:29:18 -0400 Received: from m50-138.163.com ([123.125.50.138]:51994 "EHLO m50-138.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbcDND3R (ORCPT ); Wed, 13 Apr 2016 23:29:17 -0400 X-Greylist: delayed 980 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Apr 2016 23:29:16 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=LRksy8H9DvdG81PWlG d3QsdHvKmZk1Ii2WZ6iHqG18E=; b=VXkIhh2U0bUg+KR3X5rGSPHw2FHSbAXGHE 979nVzgQqypDr9AdgCvAWJQ9mov+NRGb/mRYVcsPVL/ucbCXB15EHrVr3/yz1ULC SWKAGY8IffgPC9bz43O3npQjuYLIrTzHUxoBg7ZACn+36zTjl1Iko8A0nRJZX8ll 4jJTQZ9QU= Received: from zhaoxiuzeng-VirtualBox.spreadtrum.com (unknown [112.95.225.98]) by smtp1 (Coremail) with SMTP id C9GowABnbISjCg9XG_7WAg--.54948S2; Thu, 14 Apr 2016 11:12:39 +0800 (CST) From: zengzhaoxiu@163.com To: linux-kernel@vger.kernel.org Cc: Zhaoxiu Zeng , Dmitry Torokhov , Benjamin Tissoires , Hans de Goede , Peter Hutterer , Ulrik De Bie , Takashi Iwai , Duson Lin , linux-input@vger.kernel.org Subject: [PATCH V3 28/29] input: use parity8 in elantech Date: Thu, 14 Apr 2016 11:12:30 +0800 Message-Id: <1460603554-5854-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460601525-3822-1-git-send-email-zengzhaoxiu@163.com> References: <1460601525-3822-1-git-send-email-zengzhaoxiu@163.com> X-CM-TRANSID: C9GowABnbISjCg9XG_7WAg--.54948S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ArWrGF15uFy5Gr18Aw4ruFg_yoW8Ar1UpF W5XryUKrWkta13t34DtF4DAFyrtwn2gas8KFWkW3sYqr4UJFWSvr15JrW29FyqyF98CF4j van0yr45GFs2ka7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07bb9aPUUUUU= X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/1tbiNQdLgFSINExerQAAsu Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Zhaoxiu Zeng Remove the even parity table, use parity8 instead. Signed-off-by: Zhaoxiu Zeng --- drivers/input/mouse/elantech.c | 10 +++------- drivers/input/mouse/elantech.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 78f93cf..bbb4aa6 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -693,9 +693,9 @@ static int elantech_packet_check_v1(struct psmouse *psmouse) p3 = (packet[0] & 0x04) >> 2; - return etd->parity[packet[1]] == p1 && - etd->parity[packet[2]] == p2 && - etd->parity[packet[3]] == p3; + return parity8(packet[1]) != p1 && + parity8(packet[2]) != p2 && + parity8(packet[3]) != p3; } static int elantech_debounce_check_v2(struct psmouse *psmouse) @@ -1635,10 +1635,6 @@ int elantech_init(struct psmouse *psmouse) psmouse_reset(psmouse); - etd->parity[0] = 1; - for (i = 1; i < 256; i++) - etd->parity[i] = etd->parity[i & (i - 1)] ^ 1; - /* * Do the version query again so we can store the result */ diff --git a/drivers/input/mouse/elantech.h b/drivers/input/mouse/elantech.h index e1cbf40..542c5d9 100644 --- a/drivers/input/mouse/elantech.h +++ b/drivers/input/mouse/elantech.h @@ -141,7 +141,6 @@ struct elantech_data { unsigned int y_max; unsigned int width; struct finger_pos mt[ETP_MAX_FINGERS]; - unsigned char parity[256]; int (*send_cmd)(struct psmouse *psmouse, unsigned char c, unsigned char *param); void (*original_set_rate)(struct psmouse *psmouse, unsigned int rate); };