From patchwork Wed May 11 09:24:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zengzhaoxiu@163.com X-Patchwork-Id: 9066511 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A26F49F1C3 for ; Wed, 11 May 2016 09:25:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C2BCF20172 for ; Wed, 11 May 2016 09:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7EFB2015A for ; Wed, 11 May 2016 09:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932341AbcEKJYq (ORCPT ); Wed, 11 May 2016 05:24:46 -0400 Received: from m50-135.163.com ([123.125.50.135]:49842 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932202AbcEKJYm (ORCPT ); Wed, 11 May 2016 05:24:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=pwfnXYpnIw5aownu7y uKQfgUXzFvHiBKfwZjRxQ8pQs=; b=VvPu5p9OavV9du6g1w5TPpVYg2oQrEig3w rRVQhEIEFikVa4p0iEOAsU9ITOP6vsEnLigLFZLeNvPY4h7qfmymuFMNkwbT/DtN EYOAX6qjGVTU9YfydUAz3fqKttTN8VdIKCBt0Ue8A5y3fhm1BVZeO4juveAoKLuz PNeLVyiKk= Received: from zhaoxiuzeng-VirtualBox.spreadtrum.com (unknown [112.95.225.98]) by smtp5 (Coremail) with SMTP id D9GowADH8DxH+jJXTANDAA--.13633S2; Wed, 11 May 2016 17:24:27 +0800 (CST) From: zengzhaoxiu@163.com To: linux-kernel@vger.kernel.org Cc: Zhaoxiu Zeng , Dmitry Torokhov , Benjamin Tissoires , Hans de Goede , Takashi Iwai , Peter Hutterer , Duson Lin , Ulrik De Bie , linux-input@vger.kernel.org Subject: [patch V4 28/31] input: use parity8 in elantech Date: Wed, 11 May 2016 17:24:17 +0800 Message-Id: <1462958661-26047-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com> References: <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com> X-CM-TRANSID: D9GowADH8DxH+jJXTANDAA--.13633S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ar1UAr4UGr43tw1Uur17Jrb_yoW8AF45pF W5XryUKrWkta17tw1UtF4DAFyrtwn2gas8KFWkW3s0qr4DtFWSvr1Ut3y29FyqyFy5CF4j vFs0yr45GFs2ka7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jA4SwUUUUU= X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/xtbBDQtmgFaDm7FfkgAAsS Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Zhaoxiu Zeng Remove the parity lookup table, use parity8 instead. Signed-off-by: Zhaoxiu Zeng Acked-by: Dmitry Torokhov --- drivers/input/mouse/elantech.c | 10 +++------- drivers/input/mouse/elantech.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 78f93cf..bbb4aa6 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -693,9 +693,9 @@ static int elantech_packet_check_v1(struct psmouse *psmouse) p3 = (packet[0] & 0x04) >> 2; - return etd->parity[packet[1]] == p1 && - etd->parity[packet[2]] == p2 && - etd->parity[packet[3]] == p3; + return parity8(packet[1]) != p1 && + parity8(packet[2]) != p2 && + parity8(packet[3]) != p3; } static int elantech_debounce_check_v2(struct psmouse *psmouse) @@ -1635,10 +1635,6 @@ int elantech_init(struct psmouse *psmouse) psmouse_reset(psmouse); - etd->parity[0] = 1; - for (i = 1; i < 256; i++) - etd->parity[i] = etd->parity[i & (i - 1)] ^ 1; - /* * Do the version query again so we can store the result */ diff --git a/drivers/input/mouse/elantech.h b/drivers/input/mouse/elantech.h index e1cbf40..542c5d9 100644 --- a/drivers/input/mouse/elantech.h +++ b/drivers/input/mouse/elantech.h @@ -141,7 +141,6 @@ struct elantech_data { unsigned int y_max; unsigned int width; struct finger_pos mt[ETP_MAX_FINGERS]; - unsigned char parity[256]; int (*send_cmd)(struct psmouse *psmouse, unsigned char c, unsigned char *param); void (*original_set_rate)(struct psmouse *psmouse, unsigned int rate); };