| Message ID | 1463926811-2921-1-git-send-email-clifton.a.barnes@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, May 22, 2016 at 4:20 PM, Clifton Barnes <clifton.a.barnes@gmail.com> wrote: > The end ')' needs to be removed if the macro is ever used or there > would be a compiler error as it does not have a matching '('. > > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 23, 2016 at 03:26:56PM +0200, Linus Walleij wrote: > On Sun, May 22, 2016 at 4:20 PM, Clifton Barnes > <clifton.a.barnes@gmail.com> wrote: > > > The end ')' needs to be removed if the macro is ever used or there > > would be a compiler error as it does not have a matching '('. > > > > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Applied, thank you.
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c index e92dfd8..ec0070e 100644 --- a/drivers/input/keyboard/tc3589x-keypad.c +++ b/drivers/input/keyboard/tc3589x-keypad.c @@ -32,7 +32,7 @@ #define TC3589x_PULL_DOWN_MASK 0x1 #define TC3589x_PULL_UP_MASK 0x2 #define TC3589x_PULLUP_ALL_MASK 0xAA -#define TC3589x_IO_PULL_VAL(index, mask) ((mask)<<((index)%4)*2)) +#define TC3589x_IO_PULL_VAL(index, mask) ((mask)<<((index)%4)*2) /* Bit masks for IOCFG register */ #define IOCFG_BALLCFG 0x01
The end ')' needs to be removed if the macro is ever used or there would be a compiler error as it does not have a matching '('. Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com> --- drivers/input/keyboard/tc3589x-keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)