From patchwork Thu Jun 23 08:31:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen Hung X-Patchwork-Id: 9194675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1157A6077D for ; Thu, 23 Jun 2016 08:31:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 022E32842D for ; Thu, 23 Jun 2016 08:31:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAD112843D; Thu, 23 Jun 2016 08:31:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 842DF2842D for ; Thu, 23 Jun 2016 08:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbcFWIbt (ORCPT ); Thu, 23 Jun 2016 04:31:49 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:27575 "EHLO ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbcFWIbr (ORCPT ); Thu, 23 Jun 2016 04:31:47 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:Cc:Subject:Date: Message-Id:X-Mailer; b=TRHdo0fkAdXkREmhpE2cQJozmvaR83S/Sm98qgzJMTJUwwj5NmGolm5z hy4qty0HGBxy7ovFllp9V88eBU+WIcjzNNhBOJFuF/pS7QcSC6In5jIIA nyduARldQF3ntU+VzTEUvReA3tWcJYaEp5WXuzUMz8FY1x6Swt1mGeWNk g=; DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1466670707; x=1498206707; h=from:to:cc:subject:date:message-id; bh=+SpYdjmR9iKVW/sTqM13UAejn5a3aWGdG6GsgpEFKRQ=; b=jn6E776abux/Wm/MGBP/KAIz601Qn+gRnWjuSc6WxefPioDe3SsMEZ7R o8wzyf6AO1jko7N3lUXgXF5Uld9VBdQCTreJYGm1w+bB6Kw7n5SAkCGEQ vG0MwOiSVEnLlNFDJG3+OAzIryWh367RDrXpW8MF2jKy9B3nFon1JrT4F w=; X-LoopCount0: from 10.106.62.236 X-IronPort-AV: E=Sophos;i="5.26,509,1459832400"; d="scan'208";a="948542801" From: Allen Hung To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, LKML , Allen Hung Subject: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Date: Thu, 23 Jun 2016 16:31:29 +0800 Message-Id: <1466670690-77458-1-git-send-email-allen_hung@dell.com> X-Mailer: git-send-email 2.7.4 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection if device implements confidence usage") The commit enables palm rejection for Win8 Precision Touchpad devices but the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very properly. This quirk is originally designed for some WIn7 touchscreens. Use of this for a Win8 Precision Touchpad will cause unexpected pointer jumping problem. Signed-off-by: Allen Hung Tested-by: Andy Lutomirski # XPS 13 9350, BIOS 1.4.3 --- drivers/hid/hid-multitouch.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 95b7d61..4ef7006 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi, mt_store_field(usage, td, hi); return 1; case HID_DG_CONFIDENCE: - if (cls->name == MT_CLS_WIN_8 && - field->application == HID_DG_TOUCHPAD) { - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; - cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; - } mt_store_field(usage, td, hi); return 1; case HID_DG_TIPSWITCH: