From patchwork Thu Jul 7 16:39:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "jeffrey.lin" X-Patchwork-Id: 9219173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6136F60467 for ; Thu, 7 Jul 2016 16:40:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E8792837F for ; Thu, 7 Jul 2016 16:40:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4000F28387; Thu, 7 Jul 2016 16:40:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A0D072837F for ; Thu, 7 Jul 2016 16:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbcGGQkv (ORCPT ); Thu, 7 Jul 2016 12:40:51 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:32793 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbcGGQkt (ORCPT ); Thu, 7 Jul 2016 12:40:49 -0400 Received: by mail-pa0-f68.google.com with SMTP id ts6so2209973pac.0; Thu, 07 Jul 2016 09:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cxKqIjK/57IsW02ZuP+kK+tLVNnHp+vDrakQVbffaN4=; b=ppI+LXDXslVil6tmrzU621TXThrjrNHPkbNM2sl2BAogkG6o2krOKjoJda1pCR/uQI 22PGhtYpJ9csqB8VDe66XpTV/wTLzH+ZF/rSi8RXQKe8+ybHjLrSBWxG5JXou/qvObCN OZPune1KcMekse+340eMZdnhgGSld2DT+UWti7LHaEW02XszamWwfqx8CZW5QAEVEFPh blzUcZiUkRPQKBpL3fPiAkxFhB1CVtcijnuU7Z0tXqwm3Qy9BtuWGvQZGq8qdOBAn+6f 5Je9ZTNadXqI1dgVpWDmZvJ72QTicopV3BLSR0/5miiirG2zqt9EvXjj9iks860lqvTg h/0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cxKqIjK/57IsW02ZuP+kK+tLVNnHp+vDrakQVbffaN4=; b=XJ+1KJgscAL3OeSLxqZdUtgthippO1GQi2/mBHWGp9jzQkYPymmWv1cbmOGrfQ8/0A dKTRWQZ1/8uHm8OL/eMmg425iPB6M8vUCYF+igYRfr4aPbOTM8p/6s3J2bZ5726+sICA DqlM+c2110zx3BpfDBWWqMJEUSe9PDBJKqv6K4E1GKAhJiEbmXI8t4r4b5+tOEoqUxLO RUYXEQBG9RuHuCtSuzY6RMFtQvGqsUfHq94tQIaTwlruyr+YVyrsGpv1hPAGTXKFJq50 Unmwr8ltLbs44qwKrCax+W+8yGOc9ftlqhhNOGNhT+z60gkmBq/c5aO7g7hn/03YDFBg usUQ== X-Gm-Message-State: ALyK8tKBYfpe+yUWn36D9hwzS4RPxKD7cn/36jFammwT7JedfLW4XMTFu2PeCNymFAUUNQ== X-Received: by 10.66.118.169 with SMTP id kn9mr1792323pab.109.1467909594131; Thu, 07 Jul 2016 09:39:54 -0700 (PDT) Received: from localhost.localdomain (220-132-61-75.HINET-IP.hinet.net. [220.132.61.75]) by smtp.gmail.com with ESMTPSA id by5sm5868495pad.36.2016.07.07.09.39.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2016 09:39:53 -0700 (PDT) From: "jeffrey.lin" X-Google-Original-From: "jeffrey.lin" To: dmitry.torokhov@gmail.com, rydberg@euromail.se, groeck@chromium.org, robh@kernel.org Cc: jeffrey.lin@rad-ic.com, ealin.chiu@rad-ic.com, jason.yeh@rad-ic.com, KP.li@rad-ic.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH] [v1.1 2/3] fix reset gpio config error Date: Thu, 7 Jul 2016 09:39:00 -0700 Message-Id: <1467909540-43525-1-git-send-email-jeffrey.lin@rad-ic.com> X-Mailer: git-send-email 2.1.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ts->reset_gpio=0 will let raydium IC enter reset mode, and ts->reset_gpio=1 will be normal touch mode. Signed-off-by: jeffrey.lin --- drivers/input/touchscreen/raydium_i2c_ts.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c index f3076d9..5217339 100644 --- a/drivers/input/touchscreen/raydium_i2c_ts.c +++ b/drivers/input/touchscreen/raydium_i2c_ts.c @@ -78,7 +78,7 @@ #define RM_MAX_FW_RETRIES 30 #define RM_MAX_FW_SIZE 0xD000 -#define RM_POWERON_DELAY_USEC 500 +#define RM_POWERON_DELAY_MSEC 20 #define RM_RESET_DELAY_MSEC 50 enum raydium_bl_cmd { @@ -933,7 +933,7 @@ static int raydium_i2c_power_on(struct raydium_data *ts) if (!ts->reset_gpio) return 0; - gpiod_set_value_cansleep(ts->reset_gpio, 1); + gpiod_set_value_cansleep(ts->reset_gpio, 0); error = regulator_enable(ts->avdd); if (error) { @@ -950,10 +950,10 @@ static int raydium_i2c_power_on(struct raydium_data *ts) goto release_reset_gpio; } - udelay(RM_POWERON_DELAY_USEC); + msleep(RM_POWERON_DELAY_MSEC); release_reset_gpio: - gpiod_set_value_cansleep(ts->reset_gpio, 0); + gpiod_set_value_cansleep(ts->reset_gpio, 1); if (error) return error; @@ -968,7 +968,6 @@ static void raydium_i2c_power_off(void *_data) struct raydium_data *ts = _data; if (ts->reset_gpio) { - gpiod_set_value_cansleep(ts->reset_gpio, 1); regulator_disable(ts->vccio); regulator_disable(ts->avdd); }