diff mbox

Input: set default for iProc touchscreen

Message ID 1475950295-9660-1-git-send-email-scott.branden@broadcom.com (mailing list archive)
State New, archived
Headers show

Commit Message

Scott Branden Oct. 8, 2016, 6:11 p.m. UTC
Enable the Broadcom iProc touchscreen by default for all iProc platforms.

Signed-off-by: Ray Jui <rjui@broadcom.com>
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 drivers/input/touchscreen/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Torokhov Oct. 11, 2016, 5:49 p.m. UTC | #1
On Sat, Oct 08, 2016 at 11:11:35AM -0700, Scott Branden wrote:
> Enable the Broadcom iProc touchscreen by default for all iProc platforms.

Why? Not all of them will have touchscreen attached, will they?

Thanks.

> 
> Signed-off-by: Ray Jui <rjui@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  drivers/input/touchscreen/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 2fb1f43..f785371 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -364,6 +364,7 @@ config TOUCHSCREEN_ILI210X
>  config TOUCHSCREEN_IPROC
>  	tristate "IPROC touch panel driver support"
>  	depends on ARCH_BCM_IPROC || COMPILE_TEST
> +	default ARCH_BCM_IPROC
>  	help
>  	  Say Y here if you want to add support for the IPROC touch
>  	  controller to your system.
> -- 
> 2.5.0
>
Scott Branden Oct. 11, 2016, 6:58 p.m. UTC | #2
Hi Dmitry,


On 16-10-11 10:49 AM, Dmitry Torokhov wrote:
> On Sat, Oct 08, 2016 at 11:11:35AM -0700, Scott Branden wrote:
>> Enable the Broadcom iProc touchscreen by default for all iProc platforms.
>
> Why? Not all of them will have touchscreen attached, will they?
Correct - the touchscreen is enabled via the dtb configuration.  But, 
the default option when ARCH_BCM_IPROC is selected should have the 
driver enabled.  This avoids having to hunt around and turn on drivers 
after the upper level Kconfig options are selected.  Goal is to make it 
easy for user to get their kernel running by having defaults set 
appropriately.  If user wishes to optimize kernel size they can turn off 
drivers they do not need for their board.
>
> Thanks.
>
>>
>> Signed-off-by: Ray Jui <rjui@broadcom.com>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>  drivers/input/touchscreen/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
>> index 2fb1f43..f785371 100644
>> --- a/drivers/input/touchscreen/Kconfig
>> +++ b/drivers/input/touchscreen/Kconfig
>> @@ -364,6 +364,7 @@ config TOUCHSCREEN_ILI210X
>>  config TOUCHSCREEN_IPROC
>>  	tristate "IPROC touch panel driver support"
>>  	depends on ARCH_BCM_IPROC || COMPILE_TEST
>> +	default ARCH_BCM_IPROC
>>  	help
>>  	  Say Y here if you want to add support for the IPROC touch
>>  	  controller to your system.
>> --
>> 2.5.0
>>
>
Regards,
  Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 2fb1f43..f785371 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -364,6 +364,7 @@  config TOUCHSCREEN_ILI210X
 config TOUCHSCREEN_IPROC
 	tristate "IPROC touch panel driver support"
 	depends on ARCH_BCM_IPROC || COMPILE_TEST
+	default ARCH_BCM_IPROC
 	help
 	  Say Y here if you want to add support for the IPROC touch
 	  controller to your system.