From patchwork Mon Nov 28 18:41:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aniroop Mathur X-Patchwork-Id: 9449987 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 72BA36071C for ; Mon, 28 Nov 2016 18:32:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6886125D97 for ; Mon, 28 Nov 2016 18:32:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C48227D5E; Mon, 28 Nov 2016 18:32:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5169625D97 for ; Mon, 28 Nov 2016 18:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbcK1Sca (ORCPT ); Mon, 28 Nov 2016 13:32:30 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35598 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbcK1ScX (ORCPT ); Mon, 28 Nov 2016 13:32:23 -0500 Received: by mail-pg0-f68.google.com with SMTP id p66so13804244pga.2; Mon, 28 Nov 2016 10:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=kdMqaRRn/H4uFsqvu7MORpJuHgSajYkty+IpH8/rrs0=; b=Lq2Qvs0mSatk2mC4nVz9aXlJUUVxzrjmz0ybIllpzFa8jl54q6Ck2EYkmrC2M0BSMw 2HfE6gL2xrlDQVRQVcYBw+inslDUF2xKsnd3WaClleAlXtVwFw76JHJy8N2TccpLAiZs 4m5yNk076NIb3y4XwVTTI25DaYkZfXQJB8QOEPK5YCp3QsRcJO35AGhKhYfbPPrVRs7K s6ICz5GSzRP5G65irn4yKlPzcPxqeuHbcm+1bBmr89736l0H8ZcBPSozMfU9Se5LtBix XjXejDwSHyf2ZwWBB1ycZrNzSZMs0bCYS9SDtEut+Jge4nycOFdcsXQ8KoShusRY83i8 JjtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=kdMqaRRn/H4uFsqvu7MORpJuHgSajYkty+IpH8/rrs0=; b=G8dAUaGUc/vPiwnZvbQKNg1ZLJ3HYaO2u3PIW5q4aZiMKufDMEup2QMcOh/w32yfI5 sk1vGwKb4RdAUdGF7VkVjLNa9KL/wnx0I+6Bn3Vz/5bxwpZ/sON3m8AXojeZXGiNPELJ 0IJGLqKv64N36zIv2NsdgDm/R65tl7s5InDX4I7dDuaMD+6Tk6cm5JyEc5cJBojXHnS4 lP7Xz/16PZQWWQ06g35ElGeNO4G0diAY2ISFluIH/pBTAzKUytPpfTcIG0VChgKhoKKD iqeJt1rraYWRDH6lpq24/Khbd8Jxi+WzVF+Oi3imDpQOgs3Z6KWL7nr7Tw4+a9kJD2Um nCZg== X-Gm-Message-State: AKaTC00nza5yl8WDOkZArcSuZn9iYQxXhLVjYK/9MiI2Fl5OEHMlgv3jrhnnyXs1s7Sglg== X-Received: by 10.98.99.197 with SMTP id x188mr22927774pfb.179.1480357942861; Mon, 28 Nov 2016 10:32:22 -0800 (PST) Received: from Aniroops-MacBook-Pro.local.name ([110.172.168.122]) by smtp.gmail.com with ESMTPSA id b71sm88897968pfj.62.2016.11.28.10.32.19 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 28 Nov 2016 10:32:22 -0800 (PST) From: Aniroop Mathur To: simon.budig@kernelconcepts.de, daniel.wagener@kernelconcepts.de, LW@KARO-electronics.de, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: s.samuel@samsung.com, r.mahale@samsung.com, aniroop.mathur@gmail.com, Aniroop Mathur Subject: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs Date: Tue, 29 Nov 2016 00:11:54 +0530 Message-Id: <1480358514-2894-1-git-send-email-a.mathur@samsung.com> X-Mailer: git-send-email 2.6.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP msleep(1~20) may not do what the caller intends, and will often sleep longer. (~20 ms actual sleep for any value given in the 1~20ms range) This is not the desired behaviour for many cases like device resume time, device suspend time, device enable time, retry logic, etc. Thus, change msleep to usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur Acked-by: Simon Budig --- drivers/input/touchscreen/edt-ft5x06.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 703e295..379dd31 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -67,7 +67,7 @@ #define EDT_SWITCH_MODE_RETRIES 10 #define EDT_SWITCH_MODE_DELAY 5 /* msec */ #define EDT_RAW_DATA_RETRIES 100 -#define EDT_RAW_DATA_DELAY 1 /* msec */ +#define EDT_RAW_DATA_DELAY 1000 /* usec */ enum edt_ver { M06, @@ -664,7 +664,7 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, } do { - msleep(EDT_RAW_DATA_DELAY); + usleep_range(EDT_RAW_DATA_DELAY, EDT_RAW_DATA_DELAY + 100); val = edt_ft5x06_register_read(tsdata, 0x08); if (val < 1) break;