| Message ID | 1480717140-14558-1-git-send-email-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Dec 02 2016 or thereabouts, Brian Norris wrote: > From: Caesar Wang <wxt@rock-chips.com> > > Document a "vdd-supply" and an initialization delay. Can be used for > powering on/off a HID. > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: linux-input@vger.kernel.org > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > v2: > * add compatible property for wacom, per Rob's request > * name the regulator property specifically (VDD) > > v3: > * remove wacom property, per Benjamin's request > * add delay property > > v4: no change > --- > Documentation/devicetree/bindings/input/hid-over-i2c.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > index 488edcb264c4..1ea290167652 100644 > --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt > +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > @@ -17,6 +17,11 @@ Required properties: > - interrupt-parent: the phandle for the interrupt controller > - interrupts: interrupt line > > +Optional properties: > +- vdd-supply: phandle of the regulator that provides the supply voltage. > +- init-delay-ms: time required by the device after power-on before it is ready > + for communication. Nitpick: maybe we should say that the power-on applies to the vdd-supply parameter, not the SET_POWER HID command. I am just worried people will misuse this parameter. Otherwise, Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > + > Example: > > i2c-hid-dev@2c { > -- > 2.8.0.rc3.226.g39d4020 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2 Dec 2016, Brian Norris wrote: > From: Caesar Wang <wxt@rock-chips.com> > > Document a "vdd-supply" and an initialization delay. Can be used for > powering on/off a HID. > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: linux-input@vger.kernel.org > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > v2: > * add compatible property for wacom, per Rob's request > * name the regulator property specifically (VDD) > > v3: > * remove wacom property, per Benjamin's request > * add delay property > > v4: no change Applied both patches to for-4.10/i2c-hid. Thanks,
On Fri, Dec 9, 2016 at 6:17 AM, Jiri Kosina <jikos@kernel.org> wrote: > On Fri, 2 Dec 2016, Brian Norris wrote: > >> From: Caesar Wang <wxt@rock-chips.com> >> >> Document a "vdd-supply" and an initialization delay. Can be used for >> powering on/off a HID. >> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Jiri Kosina <jikos@kernel.org> >> Cc: linux-input@vger.kernel.org >> Signed-off-by: Brian Norris <briannorris@chromium.org> >> --- >> v2: >> * add compatible property for wacom, per Rob's request >> * name the regulator property specifically (VDD) >> >> v3: >> * remove wacom property, per Benjamin's request >> * add delay property >> >> v4: no change > > Applied both patches to for-4.10/i2c-hid. In case it wasn't clear: NAK This is still under discussion[1]. Rob [1] https://lkml.org/lkml/2016/12/8/362 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt index 488edcb264c4..1ea290167652 100644 --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt @@ -17,6 +17,11 @@ Required properties: - interrupt-parent: the phandle for the interrupt controller - interrupts: interrupt line +Optional properties: +- vdd-supply: phandle of the regulator that provides the supply voltage. +- init-delay-ms: time required by the device after power-on before it is ready + for communication. + Example: i2c-hid-dev@2c {