From patchwork Wed Jan 18 17:46:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 9524485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8E6C6020B for ; Wed, 18 Jan 2017 17:53:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DAF2C28618 for ; Wed, 18 Jan 2017 17:53:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CFCD628624; Wed, 18 Jan 2017 17:53:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8440828618 for ; Wed, 18 Jan 2017 17:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753889AbdARRwl (ORCPT ); Wed, 18 Jan 2017 12:52:41 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:58941 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753262AbdARRst (ORCPT ); Wed, 18 Jan 2017 12:48:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=References:In-Reply-To:Message-Id:Date:Subject: Cc:To:From; bh=lB0WvlgTGpa5iuG66FS5ghqIKarf+0IN8E6WLVZwAEc=; b=MbD4fb3DlrXgMk e3VN71PO1+TV0+oqxrId7PGx35fD88aAYlMOR9umoffDQFpgdizmt9dnkp9LZm05ie/lBi2TYIy+A SjC5W8ZC1+kDCKBAhvWPHL/CLdZGI2oqkMRig+qV3ttgIXNL4uY7dbD8v0pPC6yFyTyuqulsu52kv VCGYhasSDLtl+zhkbnu+07Q4fHNs3fW1LnZvFGFrDdHNwo1EvGYJjpB6wh2Mld1Fh1u2rCWFEGiI6 6+edi7Im/9PVcQedoimSsCRa7I3WfJCwk+slmX7SYWg5IUMEkrB8n0Gmc1vNE6uVoMBuLq7glUq5P Faz4seeJ1vXlLDMd2h7A==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:45182 helo=localhost) by bh-25.webhostbox.net with esmtpa (Exim 4.86_1) (envelope-from ) id 1cTuLF-001kxc-OJ; Wed, 18 Jan 2017 17:48:15 +0000 From: Guenter Roeck To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH 17/33] Input: retu-pwrbutton - Simplify error return and other changes Date: Wed, 18 Jan 2017 09:46:38 -0800 Message-Id: <1484761614-12225-18-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484761614-12225-1-git-send-email-linux@roeck-us.net> References: <1484761614-12225-1-git-send-email-linux@roeck-us.net> X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Simplify error return if the code returns anyway. Other relevant changes: Drop empty remove function This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Drop empty remove function - Replace 'if (e) return e; return 0;' with 'return e;' Signed-off-by: Guenter Roeck --- drivers/input/misc/retu-pwrbutton.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/input/misc/retu-pwrbutton.c b/drivers/input/misc/retu-pwrbutton.c index 30b459b6b344..97d39a965a65 100644 --- a/drivers/input/misc/retu-pwrbutton.c +++ b/drivers/input/misc/retu-pwrbutton.c @@ -69,21 +69,11 @@ static int retu_pwrbutton_probe(struct platform_device *pdev) if (error) return error; - error = input_register_device(idev); - if (error) - return error; - - return 0; -} - -static int retu_pwrbutton_remove(struct platform_device *pdev) -{ - return 0; + return input_register_device(idev); } static struct platform_driver retu_pwrbutton_driver = { .probe = retu_pwrbutton_probe, - .remove = retu_pwrbutton_remove, .driver = { .name = "retu-pwrbutton", },