| Message ID | 1485513756-1854-1-git-send-email-shailendra.v@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jan 27, 2017 at 04:12:36PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. > > Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> > --- > drivers/input/keyboard/tegra-kbc.c | 5 +++++ > 1 file changed, 5 insertions(+) I think that's rather pointless. The driver is OF-only, so the only way it will bind to a device is if the device's compatible matches one of the entries in the tegra_kbc_of_match table, in which case match will never be NULL. Thierry
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index 0c07e10..1f213ba 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -617,6 +617,11 @@ static int tegra_kbc_probe(struct platform_device *pdev) const struct of_device_id *match; match = of_match_device(tegra_kbc_of_match, &pdev->dev); + + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } kbc = devm_kzalloc(&pdev->dev, sizeof(*kbc), GFP_KERNEL); if (!kbc) {
of_match_device could return NULL, and so cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> --- drivers/input/keyboard/tegra-kbc.c | 5 +++++ 1 file changed, 5 insertions(+)