diff mbox

[2/4] input:touchscreen:ad7879-spi.c: Remove bits_per_word = 16 enforcement

Message ID 1487780078-18510-3-git-send-email-michael.hennerich@analog.com (mailing list archive)
State Accepted
Headers show

Commit Message

Hennerich, Michael Feb. 22, 2017, 4:14 p.m. UTC 
From: Michael Hennerich <michael.hennerich@analog.com>

Using regmap this is no longer required.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
---
 drivers/input/touchscreen/ad7879-spi.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Dmitry Torokhov Feb. 23, 2017, 8:41 a.m. UTC | #1 
On Wed, Feb 22, 2017 at 05:14:36PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> Using regmap this is no longer required.
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>

This gave me warnings about unused "err" variable, I removed it and
applied, thank you.

> ---
>  drivers/input/touchscreen/ad7879-spi.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index b995891..904a2c2 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -42,13 +42,6 @@ static int ad7879_spi_probe(struct spi_device *spi)
>  		return -EINVAL;
>  	}
>  
> -	spi->bits_per_word = 16;
> -	err = spi_setup(spi);
> -	if (err) {
> -		dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
> -		return err;
> -	}
> -
>  	regmap = devm_regmap_init_spi(spi, &ad7879_spi_regmap_config);
>  	if (IS_ERR(regmap))
>  		return PTR_ERR(regmap);
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
index b995891..904a2c2 100644
--- a/drivers/input/touchscreen/ad7879-spi.c
+++ b/drivers/input/touchscreen/ad7879-spi.c
@@ -42,13 +42,6 @@  static int ad7879_spi_probe(struct spi_device *spi)
 		return -EINVAL;
 	}
 
-	spi->bits_per_word = 16;
-	err = spi_setup(spi);
-	if (err) {
-		dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
-		return err;
-	}
-
 	regmap = devm_regmap_init_spi(spi, &ad7879_spi_regmap_config);
 	if (IS_ERR(regmap))
 		return PTR_ERR(regmap);