From patchwork Wed Jun 28 15:56:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandar Markovic X-Patchwork-Id: 9814833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8C7B660383 for ; Wed, 28 Jun 2017 16:04:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D8F728583 for ; Wed, 28 Jun 2017 16:04:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71D6E285CD; Wed, 28 Jun 2017 16:04:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2D6E28583 for ; Wed, 28 Jun 2017 16:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbdF1QEF (ORCPT ); Wed, 28 Jun 2017 12:04:05 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:51696 "EHLO mail.rt-rk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbdF1QEE (ORCPT ); Wed, 28 Jun 2017 12:04:04 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id 4E2181A4805; Wed, 28 Jun 2017 17:57:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at rt-rk.com Received: from rtrkw197-lin.domain.local (unknown [10.10.13.95]) by mail.rt-rk.com (Postfix) with ESMTPSA id 2EDE41A47F4; Wed, 28 Jun 2017 17:57:14 +0200 (CEST) From: Aleksandar Markovic To: linux-mips@linux-mips.org Cc: Lingfeng Yang , Miodrag Dinic , Goran Ferenc , Aleksandar Markovic , Dmitry Torokhov , Douglas Leung , Henrik Rydberg , James Hogan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Burton , Petar Jovanovic , Raghu Gandham Subject: [PATCH v2 5/7] input: goldfish: Fix multitouch event handling Date: Wed, 28 Jun 2017 17:56:29 +0200 Message-Id: <1498665399-29007-6-git-send-email-aleksandar.markovic@rt-rk.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498665399-29007-1-git-send-email-aleksandar.markovic@rt-rk.com> References: <1498665399-29007-1-git-send-email-aleksandar.markovic@rt-rk.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Lingfeng Yang Register Goldfish Events device properly as a multitouch device, and send SYN_REPORT event in appropriate cases only. If SYN_REPORT is sent on every single multitouch event, it breaks the multitouch. The multitouch becomes janky and having to click 2-3 times to do stuff (plus randomly activating notification bars when not clicking). If these SYN_REPORT events are supressed, multitouch will work fine, plus the events will have a protocol that looks nice. In addition, Goldfish Events device needs to be registerd as a multitouch device by issuing input_mt_init_slots. Otherwise, input_handle_abs_event in drivers/input/input.c will silently drop all ABS_MT_SLOT events, casusing touches with more than one finger not to work properly. Signed-off-by: Lingfeng Yang Signed-off-by: Miodrag Dinic Signed-off-by: Goran Ferenc Signed-off-by: Aleksandar Markovic --- drivers/input/keyboard/goldfish_events.c | 33 +++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/goldfish_events.c b/drivers/input/keyboard/goldfish_events.c index f6e643b..6e0b8bb 100644 --- a/drivers/input/keyboard/goldfish_events.c +++ b/drivers/input/keyboard/goldfish_events.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -24,6 +25,8 @@ #include #include +#define GOLDFISH_MAX_FINGERS 5 + enum { REG_READ = 0x00, REG_SET_PAGE = 0x00, @@ -52,7 +55,22 @@ static irqreturn_t events_interrupt(int irq, void *dev_id) value = __raw_readl(edev->addr + REG_READ); input_event(edev->input, type, code, value); - input_sync(edev->input); + + /* + * Send an extra (EV_SYN, SYN_REPORT, 0x0) event if a key + * was pressed. Some keyboard device drivers may only send + * the EV_KEY event and not EV_SYN. + * + * Note that sending an extra SYN_REPORT is not necessary + * nor correct protocol with other devices such as + * touchscreens, which will send their own SYN_REPORT's + * when sufficient event information has been collected + * (e.g., for touchscreens, when pressure and X/Y coordinates + * have been received). Hence, we will only send this extra + * SYN_REPORT if type == EV_KEY. + */ + if (type == EV_KEY) + input_sync(edev->input); return IRQ_HANDLED; } @@ -155,6 +173,19 @@ static int events_probe(struct platform_device *pdev) input_dev->name = edev->name; input_dev->id.bustype = BUS_HOST; + /* + * Set the Goldfish Device to be multitouch. + * + * In the Ranchu kernel, there is multitouch-specific code + * for handling ABS_MT_SLOT events (see + * drivers/input/input.c:input_handle_abs_event). + * If we do not issue input_mt_init_slots, the kernel will + * filter out needed ABS_MT_SLOT events when we touch the + * screen in more than one place, preventing multitouch with + * more than one finger from working. + */ + input_mt_init_slots(input_dev, GOLDFISH_MAX_FINGERS, 0); + events_import_bits(edev, input_dev->evbit, EV_SYN, EV_MAX); events_import_bits(edev, input_dev->keybit, EV_KEY, KEY_MAX); events_import_bits(edev, input_dev->relbit, EV_REL, REL_MAX);