From patchwork Wed Aug 9 18:21:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9891525 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3488560384 for ; Wed, 9 Aug 2017 18:22:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 254A328A70 for ; Wed, 9 Aug 2017 18:22:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1169E28ABE; Wed, 9 Aug 2017 18:22:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 989DE28A85 for ; Wed, 9 Aug 2017 18:22:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753217AbdHISVx (ORCPT ); Wed, 9 Aug 2017 14:21:53 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36185 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbdHISVu (ORCPT ); Wed, 9 Aug 2017 14:21:50 -0400 Received: by mail-pf0-f193.google.com with SMTP id t83so6838719pfj.3; Wed, 09 Aug 2017 11:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Se0Dg1CarnsPcJfD3b2HHvs7EA7KM999XrdtqhSPPL0=; b=KDIgdxpkoXE5SXY9bW8cTMfFZjNgNU2iZAoqnlYl7TlPXya86fg4ODg9jOzL6tGVJ6 rY/xFgZLp718K4JZayqCBz5t6L4R80lA7osB/vD6TAE25b0oz2w4yYlOSk1kgG+scPMw vqv0x0+ijcmfFcxY61wDVjoTXEFpZ52mTVeNVIt16xv9XT4FaJ4xI1PXNmgB9uUqdTr2 iIt5NXylLb2fp2Po0ue6e4qZEQUM/m4kF8b1dGSIrILUXrm+xc4zTyDXQFGgVxhm/TCL ORuCgQB7KQDWwdrJEIg6VY20+70SnNhgnWBu7hrLb1XDE6deRXHijPMjOWWcjWJcdN3b 6fuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Se0Dg1CarnsPcJfD3b2HHvs7EA7KM999XrdtqhSPPL0=; b=e329dIjwGkRcArlHW6XPugPQhA2zvi72GINv0A1njXNsPV/DbReck/Os3UYlMlc8Le qEis4Vh2jHEHMWAY9L3VSQIb6FHIV7DVPGqa7SJGyrPKdqJV0UyPybzPRgCfdJHZ+Ghf 1oq2DJDMuPj0FiozaiYamE/zLEzCIzwSLMe7w9NOUSegF0uFMwEJKRsdPyEQvnC1QHif pFbNIMfjdGW5KJIYaDbprRBsnnynsmowCSIsj54jYEL1+ja9rsukjGPqBh6I6WH5BYYi D7aewFHYnSpH6P4s8QdHK/CwO6uNNNwoxcBxSY5RmMySyEoYR6qirZkiOUm4QeCw2YHi 5TvA== X-Gm-Message-State: AHYfb5g2XIIjXJDjBTUdaR6333+ZX1MKWbCu5e/c1S3Zlh8fcyjthna0 PcPJa0BXKspSVg== X-Received: by 10.84.195.3 with SMTP id i3mr10079949pld.380.1502302910078; Wed, 09 Aug 2017 11:21:50 -0700 (PDT) Received: from localhost.localdomain ([103.16.68.92]) by smtp.gmail.com with ESMTPSA id r82sm10418812pfe.0.2017.08.09.11.21.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 Aug 2017 11:21:49 -0700 (PDT) From: Arvind Yadav To: jikos@kernel.org, benjamin.tissoires@redhat.com Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] HID: usbmouse: constify usb_device_id and fix space before '[' error Date: Wed, 9 Aug 2017 23:51:35 +0530 Message-Id: <1502302895-30181-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1502302895-30181-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1502302895-30181-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav --- drivers/hid/usbhid/usbmouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/usbmouse.c b/drivers/hid/usbhid/usbmouse.c index dd911c5..589ad7c 100644 --- a/drivers/hid/usbhid/usbmouse.c +++ b/drivers/hid/usbhid/usbmouse.c @@ -226,7 +226,7 @@ static void usb_mouse_disconnect(struct usb_interface *intf) } } -static struct usb_device_id usb_mouse_id_table [] = { +static const struct usb_device_id usb_mouse_id_table[] = { { USB_INTERFACE_INFO(USB_INTERFACE_CLASS_HID, USB_INTERFACE_SUBCLASS_BOOT, USB_INTERFACE_PROTOCOL_MOUSE) }, { } /* Terminating entry */