From patchwork Thu Nov 2 11:12:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?S=C3=A9bastien_Szymanski?= X-Patchwork-Id: 10038759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5472E602D8 for ; Thu, 2 Nov 2017 13:34:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 471FF28FAB for ; Thu, 2 Nov 2017 13:34:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3C36428FBB; Thu, 2 Nov 2017 13:34:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1B5628FAB for ; Thu, 2 Nov 2017 13:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755698AbdKBNeH (ORCPT ); Thu, 2 Nov 2017 09:34:07 -0400 Received: from 7.mo4.mail-out.ovh.net ([178.33.253.54]:53692 "EHLO 7.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755696AbdKBNeF (ORCPT ); Thu, 2 Nov 2017 09:34:05 -0400 X-Greylist: delayed 7793 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Nov 2017 09:34:05 EDT Received: from player746.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id E8F4DED769 for ; Thu, 2 Nov 2017 12:05:28 +0100 (CET) Received: from localhost.localdomain (124.149.193.77.rev.sfr.net [77.193.149.124]) (Authenticated sender: sebastien.szymanski@armadeus.com) by player746.ha.ovh.net (Postfix) with ESMTPSA id A6FCC5000C7; Thu, 2 Nov 2017 12:05:22 +0100 (CET) From: =?UTF-8?q?S=C3=A9bastien=20Szymanski?= To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , Julien Boibessot , =?UTF-8?q?S=C3=A9bastien=20Szymanski?= Subject: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback Date: Thu, 2 Nov 2017 12:12:44 +0100 Message-Id: <1509621164-28830-3-git-send-email-sebastien.szymanski@armadeus.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> References: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> MIME-Version: 1.0 X-Ovh-Tracer-Id: 18156261900778558534 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedttddrgeeigddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When everything goes smoothly, ret is set to 0 which makes the function to return EIO error. Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") Signed-off-by: Sébastien Szymanski --- drivers/hid/hid-cp2112.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 28e3c18..f7754a6 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -205,12 +205,13 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset) ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf, CP2112_GPIO_CONFIG_LENGTH, HID_FEATURE_REPORT, HID_REQ_SET_REPORT); - if (ret < 0) { + if (ret != CP2112_GPIO_CONFIG_LENGTH) { hid_err(hdev, "error setting GPIO config: %d\n", ret); goto exit; } - ret = 0; + mutex_unlock(&dev->lock); + return 0; exit: mutex_unlock(&dev->lock);