| Message ID | 1528983437-52903-1-git-send-email-jiazhouyang09@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 14 Jun 2018, Zhouyang Jia wrote: > When sysfs_create_group fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling sysfs_create_group. > > Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com> > --- > v1->v2: > - Remove goto statement. Applied, thanks.
diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c index 43b1c72..9bc6f48 100644 --- a/drivers/hid/hid-ntrig.c +++ b/drivers/hid/hid-ntrig.c @@ -955,6 +955,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) ret = sysfs_create_group(&hdev->dev.kobj, &ntrig_attribute_group); + if (ret) + hid_err(hdev, "cannot create sysfs group\n"); return 0; err_free:
When sysfs_create_group fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling sysfs_create_group. Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com> --- v1->v2: - Remove goto statement. --- drivers/hid/hid-ntrig.c | 2 ++ 1 file changed, 2 insertions(+)